| Re: [tcf-dev] org.eclipse.tcf.internal.cdt.ui.preferences ; x-internal:=true or not ? |
|
This package does not need to be exported in the first place. I don’t know why Scott added it to the export list. x-internal:=true looks good to me. Regards, Eugene From: tcf-dev-bounces@xxxxxxxxxxx [mailto:tcf-dev-bounces@xxxxxxxxxxx]
On Behalf Of Oberhuber, Martin Hi all, I noticed that org.eclipse.tcf.cdt.ui/META-INF/MANIFEST.MF exports org.eclipse.tcf.internal.cdt.ui.preferences without ;x-internal:=true, As a result, API Tooling reports that an @since 1.4 is missing on two new Preference constants. I am surprised that a package with .internal. in the name is not exported as ;x-internal:=true – does anybody depend on that API or is it an oversight that should be fixed ? From my POV I am fine with either adding the ;x-internal:=true or adding the missing @since tags, But one of the two actions should be taken. I’m personally more in favor of adding the ;x-internal:=true since by social convention the package was marked as internal before so it would just be made official with 1.4. Any thoughts anyone ? Thanks, Martin -- Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind
River direct +43.662.457915.85 fax +43.662.457915.6 This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. |