Hi Claes,
Eventpoint ID should be empty, *bp->id should be false, and the rest of condition should not matter.
I guess you assigned ID for eventpoint – don’t do that.
Regards,
Eugene
From: tcf-dev-bounces@xxxxxxxxxxx [mailto:tcf-dev-bounces@xxxxxxxxxxx]
On Behalf Of Lillieskold, Claes
Sent: Friday, September 25, 2015 2:41 AM
To: tcf-dev@xxxxxxxxxxx
Subject: [tcf-dev] Eventpoint Specific Check In run_bp_evaluation()
Hi,
I’m trying to use eventpoints instead of breakpoints since I require breakpoints that
are not visible to clients.
But I noticed that the eventpoints were not planted as expected, so I had to make
a modification in breakpoints.c. My question is if this modification is correct.
The modification first:
In run_bp_evaulation(), change check for number of clients from checking the list to
instead check the property client_cnt of BreakpointInfo:
if (*bp->id && list_is_empty(&bp->link_clients)) return;
to this:
if (*bp->id && bp->client_cnt == 0) return;
Rationale:
In create_breakpoint_ext(), the client count is set to 1. I assume that this is
done to get pass different checks in the code that requires at least one client.
It seems like BreakpointInfo.client_count should match the number of clients
in BreakpointInfo.link_clients, so the modification should still be correct.
Compare to breakpoints:
In add_breakpoint(), a BreakpointReference is added to the created breakpoint, and this
operation will make sure that BreakpointInfo.link_clients is not empty.
Best regards,
Claes
----------------------------------------------------------------------
Intel Sweden AB
Registered Office: Knarrarnasgatan 15, 164 40 Kista, Stockholm, Sweden
Registration Number: 556189-6027
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.