Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rdf4j-dev] I broke rdf4j-storage develop

On a related note, there is a hard dependency on logback-classic for the tools

(to be removed in 3.0 for the Console, and probably for the Workbench/server as well)

https://github.com/eclipse/rdf4j/issues/1106

 

Bart

 

From: rdf4j-dev-bounces@xxxxxxxxxxx <rdf4j-dev-bounces@xxxxxxxxxxx> On Behalf Of Jeen Broekstra
Sent: zondag 10 maart 2019 11:53
To: rdf4j developer discussions <rdf4j-dev@xxxxxxxxxxx>
Subject: Re: [rdf4j-dev] I broke rdf4j-storage develop

 

Not a huge deal for testing, but we should use the log4j slf4j bridge instead of log4j itself. The idea is to have all logging funneled through slf4j, so that a single log config can control the entire framework (including its dependencies).

 

Cheers,

 

Jeen

 

On Sun, 10 Mar. 2019, 20:01 Håvard Ottestad, <hmottestad@xxxxxxxxx> wrote:

Hi,

So I fixed develop.

The fix required:

<dependency>
   <groupId>org.apache.logging.log4j</groupId>
   <artifactId>log4j-core</artifactId>
   <version>2.11.1</version>
   <scope>test</scope>
</dependency>

I don’t know if this is required only for the test, or if it’s actually required by Elasticsearch to run. Would be strange if the latter were the case, but logging in Java is one of those “here be dragons”.

If someone on here is actually using the elasticsearch sail and care to test that it still works with develop, would be great :)

Cheers,
Håvard



> On 10 Mar 2019, at 09:07, Håvard Ottestad <hmottestad@xxxxxxxxx> wrote:
>
> Hi,
>
> Merged in the new elasticsearch version and it broke develop. Jenkins didn’t complain on the PR :(
>
> This is the issue:
>
> Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/logging/log4j/core/Layout
>       at java.base/java.lang.Class.getDeclaredMethods0(Native Method)
>       at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3139)
>       at java.base/java.lang.Class.getMethodsRecursive(Class.java:3280)
>       at java.base/java.lang.Class.getMethod0(Class.java:3266)
>       at java.base/java.lang.Class.getMethod(Class.java:2063)
>       at org.junit.internal.builders.SuiteMethodBuilder.hasSuiteMethod(SuiteMethodBuilder.java:18)
>       at com.intellij.junit4.JUnit46ClassesRequestBuilder.collectWrappedRunners(JUnit46ClassesRequestBuilder.java:75)
>       at com.intellij.junit4.JUnit46ClassesRequestBuilder.getClassesRequest(JUnit46ClassesRequestBuilder.java:47)
>       at com.intellij.junit4.JUnit4TestRunnerUtil.buildRequest(JUnit4TestRunnerUtil.java:90)
>       at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:46)
>       at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
>       at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
>       at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> Caused by: java.lang.ClassNotFoundException: org.apache.logging.log4j.core.Layout
>       at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:582)
>       at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:185)
>       at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:496)
>       ... 13 more
>
> Cheers,
> Håvard

_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/rdf4j-dev

Back to the top