[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
[qvto-dev] Second batch of Christopher's patches
|
Hi
I've just checked through
https://bugs.eclipse.org/bugs/show_bug.cgi?id=398009
and the current state is
https://bugs.eclipse.org/bugs/show_bug.cgi?id=254962 looks good, simple
rework to rereview
https://bugs.eclipse.org/bugs/show_bug.cgi?id=296630 +1, fix copyright
https://bugs.eclipse.org/bugs/show_bug.cgi?id=358709 +1, trivial comment
https://bugs.eclipse.org/bugs/show_bug.cgi?id=376274 +1
https://bugs.eclipse.org/bugs/show_bug.cgi?id=388329 +1
https://bugs.eclipse.org/bugs/show_bug.cgi?id=388331 +1, extra JUnit
test would be good
https://bugs.eclipse.org/bugs/show_bug.cgi?id=388801 looking good, rereview
https://bugs.eclipse.org/bugs/show_bug.cgi?id=390182 review pending
https://bugs.eclipse.org/bugs/show_bug.cgi?id=394188 +0.5, rereview
so it looks like at least 7, possibly all 9, can go into M6.
Christopher has never used GIT, so it's probably best to delay his GIT
activities until after Kepler, as I originally suggested.
Christopher: if you clone the QVTo repo using git: rather than ssh:
access you can do whatever you like in your local copy without any risk
of accidentally pushing upstream. If you later want to rescue rather
than rework changes, you can clone another repo with ssh: and set it as
the upstream of your original. The EGIT tutorials are quite helpful, but
I've not seen any that takes a CVS conversion perspective, so I found
some things strange. http://wiki.eclipse.org/MDT/OCL/Dev/EGit has some
additional thoughts that I found helpful (needs updating in the light of
more experience).
Christopher: can you take a shot at the extra completion test for
388331? I suspect you just need to add a dataset to the UI tests.
Adolfo: do you want to start committing these after completing and
rereviews?
Regards
Ed