[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
[qvto-dev] Christopher Gerking's contributions
|
Hi
https://bugs.eclipse.org/bugs/show_bug.cgi?id=398009 has been raised
with a spreadsheet attached to guide us through the many patches.
I've reviewed the main cumulative patch for 12 bugs. Pretty good: old
tests pass, new tests demonstrate progress. Changes are mostly simple
but look good and preserve existing style.
One API issue needs to be addressed; it's probably easy. Beyond that my
comments are trivial.
I don't feel competent to comment further on the detailed changes.
Sergey: the changes are relatively small, so applying the patches and
then using the GIT staging view as a browser makes the review fairly
easy. It would be good to have your input.
Adolfo: since the changes are mostly associated with evaluation,
examining the changes may be a useful introduction to the code.
I'd like to get these bugs fixed for M5 (start of February). Since these
demonstrate that Christopher understands the project and its testing, I
think we can use these 12 bugs as justification for a QVTo committer
election so that Christopher can then commit the other 8 himself for M6
(after review).
Regards
Ed Willink