Done. I believe that increasing the sequence number is problematic for target definitions shared in an SCM and 50ish developers reloading it every day. Let’s continue the discussion on the bug.
-Gunnar Gunnar, can you weigh in on Bug 439034. I'm considering adding a reload button on the editor that would increase the sequence number. It would probably make sense to change the reload button on the preference page to also increment the sequence number.
Curtis
<graycol.gif>Curtis Windatt---07/10/2014 02:35:17 PM---While I haven't confirmed it, the reload button will NOT look for newer updates as the sequence numb
From: Curtis Windatt/Ottawa/IBM@IBMCA
To: "Eclipse PDE general developers list." <pde-dev@xxxxxxxxxxx>,
Date: 07/10/2014 02:35 PM
Subject: Re: [pde-dev] Target Definition update/resolution problems
Sent by: pde-dev-bounces@xxxxxxxxxxx
While I haven't confirmed it, the reload button will NOT look for newer updates as the sequence number will not change (assuming the target has been resolved previously).
Paul has brought up a related issue, which is if there is a problem getting the p2 contents, the p2 profile may still be updated with the current sequence number. This means opening the editor will not fix the broken contents. A reload button may become necessary (though I want to also have some recovery code).
https://bugs.eclipse.org/bugs/show_bug.cgi?id=439034
Curtis
<graycol.gif>Gunnar Wagenknecht ---07/08/2014 05:28:53 PM---Am 08.07.2014 um 22:18 schrieb Curtis Windatt <Curtis_Windatt@xxxxxxxxxx>: > No, PDE will not ping t
From: Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx>
To: "Eclipse PDE general developers list." <pde-dev@xxxxxxxxxxx>,
Date: 07/08/2014 05:28 PM
Subject: Re: [pde-dev] Target Definition update/resolution problems
Sent by: pde-dev-bounces@xxxxxxxxxxx
Am 08.07.2014 um 22:18 schrieb Curtis Windatt <Curtis_Windatt@xxxxxxxxxx>:
No, PDE will not ping the repository to check for newer versions unless the sequence number is increased. Pressing the update button (with the fix) will ping the remote repository and take the latest version (without changing the 0.0.0 setting).
Good to know. AFAIK in 4.3 it replaced the 0.0.0 with the latest version.
If that workflow is a problem, please open a bug. The likely solution would be to make a p2 target location dirty on creation if it has an IU with 0.0.0. This would make the behaviour similar to 4.3. Note that if such a target was set as the target platform, the p2 repositories would be contacted on startup (when the PDE models were created), possibly causing delays in the UI.
Actually, the behavior does make a lot sense. I always wanted to have more control when PDE goes out to the remote repos. Knowing that it will only when you click the "update" button is good (I think). Maybe it’s now time to have a "reload" button for the whole target definition in the target editor?
Btw, will the reload button in the preferences also cause a fetch of newer versions from remote repositories if 0.0.0 is being used?
-Gunnar
--
Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx
_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pde-dev_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pde-dev
_______________________________________________ pde-dev mailing list pde-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/pde-dev
|