Re: [pde-dev] About illegally instantiation of ModelChangedEvent

[Daniel Megert <daniel_megert@xxxxxxxxxx>]

The developer did not break the rule. The
restriction (API tag) was introduced a long time after that code was written.
Since PDE UI and PDE Core are closely related, there's no urgent need to
get rid of the warning.

When analyzing the API Tools reports
you need to be aware that API Tools along with the API tags got introduced
late in the live of Eclipse (R3.4 / 2008). Before that, the API restrictions
were just "normal" comments in the Javadoc - if at all.

Dani


From:      
 João Arthur <joaoarthurbm@xxxxxxxxx>
To:      
 pde-dev@xxxxxxxxxxx
Date:      
 27.08.2013 23:02
Subject:    
   [pde-dev] About
illegally instantiation of ModelChangedEvent
Sent by:    
   pde-dev-bounces@xxxxxxxxxxx

---

Hi guys, my name is João Brunet and I'm a
PhD student at UFCG - Brazil, currently visiting professor Gail Murphy
at University of British Columbia.

In my PhD, I'm analyzing the API
Tools Verification Reports of Eclipse project. I'm collecting some
interesting observations from this data. However, I need some of specialists'
opinion about these tests results. Would mind to answer me a quick question
about this warning?

org.eclipse.pde.internal.ui.editor.plugin.PluginInputContextManager
illegally instantiates org.eclipse.pde.core.ModelChangedEvent generated
by the following code:

private void transferListeners(IModel
source, IModel target) {
...
     smodel.fireModelChanged(new
ModelChangedEvent(smodel, IModelChangedEvent.WORLD_CHANGED,
null, null));
    
...
}

source-code
link.

My question is: Why did the developer
break the rule?


Thank you in advance!  I would
be very grateful if you help me. Your opinion will improve a lot my results.


João_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev