Hi,
As a latecomer to the project, I have to ask why hyphens in project names are bad. Many, if not most, Eclipse Projects use feature IDs that are the same as their lead plug-in IDs, and so append a “-feature” on the name of the feature project to make it distinct in the workspace from the bundle project of the same name. This avoids the redundant suffix “.feature” in the actual feature ID, which the results in a p2 IU name with “.feature.feature.group”.
Anyways, I can certainly postpone any requests to the Oomph team for cataloguing our setup model until we have settled the issue at hand. Developers can always add the setup to their User Projects from their git checkout.
But, now that you mention it, this reminds me of a problem that we have in Papyrus that would perhaps best be avoided here while we have the chance. The problem is that the setup model actually includes information for all development streams of the project, which means that it doesn’t make much sense for it to be hosted within the same Git repository as the source code that is branched for those various development streams. In Papyrus we are now maintaining the setup model on the master branch only, which means that if you’re working on (e.g.) Mars branch, then you have to switch back-and-forth to the master branch to work on the setup model. Very cumbersome.
So, I would rather maintain this setup model for Papyrus-RT in the web repository. The extra benefit of this is that then the Oomph Catalogue can reference it on the Papyrus-RT website, which by-passes the Git repository viewer. That would make our Webmasters very happy (the web server takes quite a hit whenever Oomph requests resources from the git viewer).
Comments?
Christian On 7 April, 2016 at 11:36:38, Peter Cigéhn (peter.cigehn@xxxxxxxxx) wrote:
Hi,
I have not looked at the
latest patch set yet, I just wanted to give a quick comment, since
I saw that you wanted to get the model added to the Oomph catalogue
(which I think will be great).
As part of https://git.eclipse.org/r/#/c/69746/ Celine
proposed to rename the project in which this setup-file is placed.
Celine's argument was that it needed to follow naming rules which
disallows '-' to be included in the project name. I made the
comment that any change to the project name, will impact the
installation instructions, including any users that already have
followed these instructions and now have a reference to the setup
file via a plain git resource link as given by the instructions
at https://wiki.eclipse.org/Papyrus-RT/User_Guide/Eclipse_Installer
Since I do know that the
Oomph catalogue uses exactly the same approach using a plain git
resource link, we will "bump into" yet another issue if we later
decide to change the name of the project containing these
setup-files, then with both the product setup files as well as the
new project setup files.
So I would really like to
settle the name of this project. I do know that Celine reverted the
name of the project in later patch sets of that Gerrit change, but
I guess Celine still thinks that the project should align its
names. As I indicated in that Gerrit change, I think that Charles
should give his view on any name change, since it will impact the
installation guide (which Charles has mainly worked with) and the
aspect on the impact on any existing users that now has references
to a file in this project in the Git repo.
Simplest would of course
be if we just accepted that this project keep its name which does
not follow the naming conventions. But I don't know what kind of
impact that will have.... Celine, please give your view regarding
this.
/Peter Cigéhn
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
|