Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orbit-dev] (Newbie) Adding to the orbit build

Hi Chris,

  Thanks for the review.

  I am adding:

- javax.persistence 1.0.0 - this is mostly added. I am planning on adding the source bundle when I know I have properly added the binary to the build. (preparing the changes now) - commonj.sdo 2.1.1 - in progress. I'll do my best to integrate your changes from the javax.persistence check-in.

  Where is iplog.xml?

Thanks,
-Tom

Chris Aniszczyk wrote:
On Fri, May 1, 2009 at 10:42 AM, Tom Ware <tom.ware@xxxxxxxxxx <mailto:tom.ware@xxxxxxxxxx>> wrote:

    No prob...

    Silly question: "Bundle" seems to be used to describe a couple of
    things in the various docs.  Do you want me to post an exported jar,
    or something else?


A listing of what bundles you're adding would be good. I just browsed the javax.persistence one and fixed a couple things. A couple things I noticed was there was no source (could be OK in this case ;p), a build.xml that shouldn't be there, not externalized MANIFEST.MF entries etc...

Make sure to update the iplog xml files anyway :)

Cheers,

--
Chris Aniszczyk | EclipseSource Austin | +1 860 839 2465
http://twitter.com/eclipsesource | http://twitter.com/caniszczyk


------------------------------------------------------------------------

_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev


Back to the top