| Re: [orbit-dev] orbit-S build.133 Build Fixed ... almost |
Yep, the code currently checks to ensure that the produced bundles contain at least some of the right files. I'm not an Ant guy so I did it in Java. :-)
It has default values if you don't specify anything specific for your bundle... makes sure that all binary bundles contain at least one class file or a jar, etc. and source bundles have a java file. It also checks that the bundles have at least an about.html file.
If this can be done easier in Ant by your scripts, then feel to replace what we currently have... I only wrote it because we were having problems getting bundle formats right/consistent at the beginning of Orbit.
orbit-dev-bounces@xxxxxxxxxxx wrote on 01/23/2009 10:02:07 AM:
> Test code to verify contents of a bundles ?
>
> Here's how I do it in ant for SWTBot. It looks at the generated
> artifact, extract it, recurse through the plugins and features to figure
> out if necessary files are present.
>
> I'd be happy to put it into orbit.
>
> <target name="verify-generated-artifacts" description="check if the
> artifacts are compliant with the legal docs
> http://www.eclipse.org/legal/guidetolegaldoc.php and
> http://www.eclipse.org/legal/guidetolegaldoc2.php">
> <delete dir="target/check-licenses" />
> <unzip dest="target/check-licenses"
> src="" />
>
> <for param="feature-jar">
> <dirset dir="target/check-licenses/eclipse/features" includes="*" />
> <sequential>
> <echo>Verifying feature @{feature-jar}</echo>
>
> <available file="@{feature-jar}/feature.xml"
> property="feature.xml.available" />
> <fail unless="feature.xml.available" message="feature.xml for
> feature @{feature-jar} is not available" />
>
> <available file="@{feature-jar}/license.html"
> property="license.html.availble" />
> <fail unless="license.html.availble" message="license.html for
> feature @{feature-jar} is not available" />
>
> <available file="@{feature-jar}/epl-v10.html"
> property="epl-v10.html.available" />
> <fail unless="epl-v10.html.available" message="epl-v10.html for
> feature @{feature-jar} is not available" />
> </sequential>
> </for>
>
> <for param="plugin-jar">
> <fileset dir="target/check-licenses/eclipse/plugins"
> includes="org.eclipse.*" />
> <sequential>
> <echo>Verifying plugin @{plugin-jar}</echo>
>
> <available classpath="@{plugin-jar}" resource="about.html"
> ignoresystemclasses="false" property="about.html.available" />
> <fail unless="about.html.available" message="about.html for
> plugin @{plugin-jar} is not available" />
>
> <available classpath="@{plugin-jar}" resource="LICENSE.EPL"
> ignoresystemclasses="false" property="LICENSE.EPL.available" />
> <fail unless="LICENSE.EPL.available" message="LICENSE.EPL for
> plugin @{plugin-jar} is not available" />
> </sequential>
> </for>
> </target>
>
> -- Ketan
>
> On 23/1/09 19:55, DJ Houghton wrote:
> > Yes, you can add an exclude rule to the test. Unfortunately the test
> > only handles it on a per-bundle basis right now. (doesn't take the
> > version into account)
> >
> > It would be pretty easy to modify though if you wanted to look at it.
> > The code is in the project:
> > org.eclipse.orbit.releng.tests
> >
> >
> > Inactive hide details for Gunnar Wagenknecht
> > <gunnar@xxxxxxxxxxxxxxx>Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx>
> >
> >
> > *Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx>*
> > Sent by: orbit-dev-bounces@xxxxxxxxxxx
> >
> > 01/23/2009 02:01 AM
> > Please respond to
> > Orbit Developer discussion <orbit-dev@xxxxxxxxxxx>
> >
> >
> >
> > To
> >
> > Orbit Developer discussion <orbit-dev@xxxxxxxxxxx>
> >
> > cc
> >
> >
> > Subject
> >
> > Re: [orbit-dev] orbit-S build.133 Build Fixed ... almost
> >
> >
> >
> >
> > Hi David,
> >
> > David M Williams schrieb:
> > > Missing pattern: .*.(class|jar)$ in file:
> > >
> > /shared/orbit/projects/orbit-
> S/workdir/S20090123045900/bundles/org.apache.lucene_2.4.0.v20090121-2110.jar
> >
> > > I think this means the lucene jar has no java content
> >
> > That's intentional. The bundle was refactored into multiple "child"
> > bundles. It now only re-exports split-packages from its "children" but
> > does not come with any Java content.
> >
> > https://bugs.eclipse.org/bugs/show_bug.cgi?id=260034
> >
> > Can we add an exclusion rule to the test?
> >
> > -Gunnar
> >
> > --
> > Gunnar Wagenknecht
> > gunnar@xxxxxxxxxxxxxxx
> > http://wagenknecht.org/
> >
> > [attachment "signature.asc" deleted by DJ Houghton/Ottawa/IBM]
> > _______________________________________________
> > orbit-dev mailing list
> > orbit-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/orbit-dev
> >
> >
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > orbit-dev mailing list
> > orbit-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/orbit-dev
> _______________________________________________
> orbit-dev mailing list
> orbit-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/orbit-dev