Re: [mylyn-reviews-dev] Inline commenting inside gerrit connector

[Steffen Pingel <steffen.pingel@xxxxxxxxxxx>]

What is the latest time that would work for anyone in Europe?

Steffen


On Fri, Jan 21, 2011 at 12:00 PM, Matthias Sohn
<matthias.sohn@xxxxxxxxxxxxxx> wrote:
> 2011/1/21 Steffen Pingel <steffen.pingel@xxxxxxxxxxx>
>>
>> The problem is that we have separate models for the three reviews
>> implementations at the moment:
>>
>>  332593: merge o.e.m.reviews.core and o.e.m.review.frame.core models
>>  https://bugs.eclipse.org/bugs/show_bug.cgi?id=332593
>>
>> The o.e.m.review.frame.core model did not meet all requirements for
>> the Gerrit connector and I had the impression that changing it would
>> break R4E.
>>
>> I would like to converge on a single framework model and to consume
>> that in the Gerrit connector. We could then move the inline commenting
>> code into a common framework (UI) bundle and consume that in all
>> review implementations. The overall goal being to share the
>> offline/persistence layer and UI components.
>>
>> Maybe it would be best if we setup a call sometime next week to make
>> sure we are all on the same page and discuss if it makes sense to
>> continue to follow that approach?
>
> Would be nice if we find a time matching both ends.
> The mylyn project call isn't reachable for me as it's at 7pm our time and
> this is family time on my end.
> --
> Matthias
>
> _______________________________________________
> mylyn-reviews-dev mailing list
> mylyn-reviews-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>
>



-- 
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com