Re: [mylyn-reviews-dev] line based commenting

[Steffen Pingel <steffen.pingel@xxxxxxxxxxx>]

You will need additional plug-ins that are not part of the CQ and hosted on Github. You can find the details in this message and follow up mails:

http://dev.eclipse.org/mhonarc/lists/mylyn-reviews-dev/msg00029.html

Steffen

On Fri, Oct 8, 2010 at 7:47 AM, Sascha Scholz <sascha.scholz@xxxxxxxxx> wrote:

Hi Steffen,

I've tried to get the line-based commenting feature running, so far
with no luck:

- Bundle 'com.atlassian.connector.eclipse.model' cannot be resolved

Where can I get this one from?


- Missing imports in SelectChangesetsFromCruciblePage.java:
import com.atlassian.connector.eclipse.ui.viewers.ArrayTreeContentProvider;
import com.atlassian.theplugin.commons.crucible.api.model.Repository;
import com.atlassian.theplugin.commons.crucible.api.model.changes.Change;
import com.atlassian.theplugin.commons.crucible.api.model.changes.Changes;
import com.atlassian.theplugin.commons.crucible.api.model.changes.Revision;
import com.atlassian.theplugin.commons.util.MiscUtil;

Are these related to the missing bundle? Is this class needed at all?
I could remove it without further build errors.


- Errors when trying to run it:

An error has occurred. See error log for more details.
Plug-in com.atlassian.connector.eclipse.crucible.ui was unable to load
class com.atlassian.connector.eclipse.internal.crucible.ui.editor.ruler.CommentAnnotationRulerColumn.
com.atlassian.connector.eclipse.internal.crucible.ui.editor.ruler.CommentAnnotationRulerColumn

org.eclipse.core.runtime.CoreException: Plug-in
com.atlassian.connector.eclipse.crucible.ui was unable to load class
com.atlassian.connector.eclipse.ui.commons.EditorResourceAdapterFactory.
...
Caused by: java.lang.ClassNotFoundException:
com.atlassian.connector.eclipse.ui.commons.EditorResourceAdapterFactory
...

Any ideas how to fix it?

Thanks,
Sascha

On Fri, Oct 1, 2010 at 8:53 AM, Kilian Matt

<kilian.matt@xxxxxxxxxxxxxxxxx> wrote:

> Hi,
>
> I've just filed the CQ4509 for this.
>
> Kilian
>
> On Fri, Oct 1, 2010 at 5:58 AM, Steffen Pingel
> <steffen.pingel@xxxxxxxxxxx> wrote:
>> Hi,
>>
>> I have posted a contribution based on the Atlassian Connector for
>> Eclipse to support line-based commenting to this bug:
>>
>>  bug 326729: support line-based commenting
>>  https://bugs.eclipse.org/bugs/show_bug.cgi?id=326729
>>
>> I have contacted Atlassian to confirm that we can proceed with filing
>> a CQ and will let you know when I hear back.
>>
>> Steffen
>>
>> --
>> Steffen Pingel
>> Committer, http://eclipse.org/mylyn
>> Senior Developer, http://tasktop.com
>> _______________________________________________
>> mylyn-reviews-dev mailing list
>> mylyn-reviews-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>>
> _______________________________________________
> mylyn-reviews-dev mailing list
> mylyn-reviews-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev
>
_______________________________________________
mylyn-reviews-dev mailing list
mylyn-reviews-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mylyn-reviews-dev

--
Steffen Pingel
Committer, http://eclipse.org/mylyn
Senior Developer, http://tasktop.com