[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [mylyn-dev] moving https://git.eclipse.org/r/#/c/44638/ forward ?
|
On 9 Apr 2015, at 16:20, David Green wrote:
That's a shame Max but I understand if you don't want to continue.
I pushed an update.
If you decide to continue with this and don't want to break the review
down
I'll still facilitate with code reviews but please understand that
larger
reviews do take longer. Also keep in mind that occasionally I am busy
with
other things and may not get to reviewing right away, though I'll do
what I
can to keep turn-around times short.
I know - and I have the same problem.
Which is why I did reduced it to the simplest form that would get it
below 1000 lines
- the code in the second gerrit is mainly tests now.
The actual code is 95% copy of code from markdown thus I don't think you
should have much concerns about it :)
I would just really prefer to get this through and in since right now it
blocks me from
actually trying to add more complete features on it since I can't keep
rebasing my branches.
/max
David
On Wed, Apr 8, 2015 at 9:58 PM, Max Rydahl Andersen
<manderse@xxxxxxxxxx>
wrote:
Okey. So I'm now inclined to just retract this since I cannot keep
spending time reorganizing basic stuff into small unusable pieces.
I did reduce it below 1000 lines by reducing the test coverage to be
included later.
You rejected that and I did nothing but just add the tests you asked
for.
Now it's above 1000 lines.
There is no additional logic in this stuff. Just the tests.
If you want me to split this up even further this is going to take
several
weeks to get in and I and you get to spend ages handling manual
rebase and
merge errors trying to split this up in. 5+ Gerrit reviews.
/max
http://about.me/maxandersen
On 08 Apr 2015, at 23:20, David Green <david.green@xxxxxxxxxxx>
wrote:
Max,
Apologies but it's been a busy time and I haven't had a chance to
provide
a review.
Generally you'll find turn-around on reviews is much faster if the
reviews
have 300 lines of code or less (1500+ lines of code is *very*
difficult to
review). It would be really helpful if you followed my last comment:
How about cutting this down to just the language class, it's bare
necessities and a paragraph block? That would make it easy to add
corresponding tests, and would keep the review quite small.
Subsequent
reviews could introduce one or two additional blocks at a time,
making each
review self-contained with the corresponding test coverage.
Ideally that would result in small incremental reviews.
David
On Wed, Apr 8, 2015 at 2:05 PM, Max Rydahl Andersen
<manderse@xxxxxxxxxx>
wrote:
Hey,
How do we get https://git.eclipse.org/r/#/c/44638/ to move forward ?
I've submitted the gerrit update 6 days ago which David Green said
should
be simple to get CQ done for.
When that is done I can get remaining ~1000 or so lines in as
separate
commits.
Thank you,
/max
http://about.me/maxandersen
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-dev
--
David Green
VP of Architecture, Tasktop
Committer, Eclipse Mylyn
http://tasktop.com
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-dev
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-dev
--
David Green
VP of Architecture, Tasktop
Committer, Eclipse Mylyn
http://tasktop.com
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mylyn-dev
/max
http://about.me/maxandersen