Re: [mpc-dev] Neon.2 behavior change for Nodes

[Carsten Reckord <reckord@xxxxxxxx>]

Carl,

Yes, that sounds like a regression. While IMarketplaceService.getNodes(...) is new API (hence no regression there on its own), it's been used in a couple of places internally, where previously your use case would have worked and now doesn't.

Can you create a bug for this? I'll make sure to change the implementation of DefaultMarketplaceService.getNodes(...) to support a mix of id and url references - probably collecting all ids to query them in bulk, then querying the remaining nodes by url and reassembling the results in the proper order.

Thanks,
Carsten

> -----Original Message-----
> From: mpc-dev-bounces@xxxxxxxxxxx [mailto:mpc-dev-bounces@xxxxxxxxxxx] On
> Behalf Of Carl Anderson
> Sent: Monday, February 6, 2017 11:09 PM
> To: Communication between MPC committers <mpc-dev@xxxxxxxxxxx>
> Subject: [mpc-dev] Neon.2 behavior change for Nodes
> 
> Folks,
> 
> An adopter wrote some code that extends the Eclipse Marketplace Client. It
> has been creating Nodes by using
> org.eclipse.epp.mpc.core.service.QueryHelper.nodeByURL() As of
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=507556 , the
> DefaultMarketplaceService now goes through a list of Nodes and throws a
> CoreException if a Node does not have an id set- see line 323 of
> DefaultMarketplaceService. I will open a bug once I know- are only Nodes
> with the id explicitly set supported? (In which case QueryHelper should be
> updated to parse the URL and update the id.) Or should Nodes with only a
> valid URL be supported? (In which case
> DefaultMarketplaceService.getNodes() should be updated.)
> Note: The adopter creates two different formats of URLs:
> http://marketplace.eclipse.org/node/[nodeid]
> http://marketplace.eclipse.org/content/[title]
> The second URL does not include the node id, which begs the question- is
> that format no longer supported? Or will the MPC also be changed to handle
> the content format as well as the node format?
> 
> FWIW,
> 
> - Carl Anderson
> WTP PMC Lead