In my opinion, if it’s only broken for Java 17 and we haven’t received any complaints for this on MAT 1.12, then I don’t think it’s worth the effort as we can just suggest people use Java 11 until MAT 1.14.
Kevin Grigorenko
IBM App Platform SWAT
From:
mat-dev <mat-dev-bounces@xxxxxxxxxxx> on behalf of Andrew Johnson <andrew_johnson@xxxxxxxxxx>
Date: Wednesday, June 15, 2022 at 11:22 AM
To: Memory Analyzer Dev list <mat-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [mat-dev] Next release of Memory Analyzer for Eclipse 2022-06
It’s not quite as straightforward for the 1.13.0 release. I made the change and the snapshot build looks good, and the help works with Java 17 (tested on Windows).
However the mat-standalone-packages build is designed to take as the input
This Message Is From an External Sender
|
This message came from outside your organization.
|
|
|
It’s not quite as straightforward for the 1.13.0 release.
I made the change and the snapshot build looks good, and the help works with Java 17 (tested on Windows).
However the mat-standalone-packages build is designed to take as the input the repo we used for the Eclipse simultaneous release, so for 2022-06 is download.eclipse.org/mat/2022-06/M2/
This has the plugins, and the features, including org.eclipse.mat.ui.rcp.feature_1.13.0.202204291409.jar which is the previous version without the mention of org.eclipse.jdt.core
This means that when mat-standalone-packages builds the zips then org.eclipse.jdt.core is not included, and the help problem occurs with Java 17.
So we could copy the latest snapshot build to download.eclipse.org/mat/2022-06/standalone/ (to keep it somewhere), and then do a mat-standalone-packages build from there, but the standalone build would then
have different dates from the simultaneous release version. The code in /mat/latest/update-site and /mat/1.13.0/update-site would then be later than the code in the main Eclipse site, /releases/2022-06 Would that matter? It’s possible that after installing
MAT into Eclipse from /releases/2022-06 that MAT would then see a later version in /mat/latest/update-site which would be offered as an update.
Options:
- Ship standalone MAT with broken help on Java 17
- Run mat-standalone-packages from mat/2022-06/M2
- Notarize
- Use mat-promote-release to copy to the final locations with a date of 202204291409
- Fix the standalone version
- Copy the fixed snapshot build using prepare_simrel_contribution to mat/2022-06/standalone
- Run mat-standalone-packages from mat/2022-06/standalone update site
- Notarize
- Use mat-promote-release to copy to the final locations with a date of 202206151457
Andrew Johnson
From: mat-dev <mat-dev-bounces@xxxxxxxxxxx>
On Behalf Of Kevin Grigorenko
Sent: 15 June 2022 15:45
To: Memory Analyzer Dev list <mat-dev@xxxxxxxxxxx>
Subject: Re: [mat-dev] Next release of Memory Analyzer for Eclipse 2022-06
If the solution is just the extra org.eclipse.jdt.core dependency, then that seems reasonable. Some users run MAT on intranets without internet access and I have seen them use help contents in some cases and
in that case, the workaround of “Install New Software } Eclipse 2022-03 } Eclipse Java Development Tools” won’t work (unless they download an offline update site for that which isn’t easy).
Kevin Grigorenko
IBM App Platform SWAT
I have tagged the source and run the standalone packaging build and added 1.13 as a version to Bugzilla
I have now found a problem with the standalone version (not a problem for MAT installed into Eclipse).
580157: Help fails with HTTP ERROR 500 org.apache.jasper.JasperException: PWC6033 with Java 17
https://bugs.eclipse.org/bugs/show_bug.cgi?id=580157
This problem also occurs with MAT 1.12.0 and Java 17, but no one has reported it over the past year. Do we live with this problem, caused by the following, or attempted to work around it by “-
a workaround: you should add the org.eclipse.jdt.core as a dependency to your project. (yes, it's an extra 7MB)”. I think it is just a case of adding the plugin to org.eclipse.mat.ui.rcp.feature/feature.xml
574937: [17] org.apache.jasper.JasperException: PWC6033: Error in Javac compilation for JSP PWC6197: org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException
https://bugs.eclipse.org/bugs/show_bug.cgi?id=574937
578221: HTTP ERROR 500 org.apache.jasper.JasperException: PWC6033: Error in Javac compilation for JSP PWC6197: An error occurred at line: 41 in the jsp file: /index.jsp PWC6199: Generated servlet error: System
cannot be resolved
https://bugs.eclipse.org/bugs/show_bug.cgi?id=578221
The release review is ongoing:
https://projects.eclipse.org/projects/tools.mat/reviews/1.13.0-release-review
Andrew Johnson
Unless otherwise stated above:
IBM United Kingdom Limited
Registered in England and Wales with number 741598
Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU
Unless otherwise stated above:
IBM United Kingdom Limited
Registered in England and Wales with number 741598
Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU