[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [m2e-dev] M2E's Maven-Runtime projects reworked
|
This might be a bug then if you look at line 65 there is a comment that
indicates that actually java 11 is not targeted (yet).
As said maven-runtime should use Java 1.8, rest of m2e uses Java 17.
Am 25.11.22 um 10:39 schrieb Konrad Windszus:
Maven Runtime uses JRE11 in
https://github.com/eclipse-m2e/m2e-core/blob/052d41c96f8af79200213c9e0982d23e5e02164b/m2e-maven-runtime/org.eclipse.m2e.maven.runtime/src/main/java/org/eclipse/m2e/internal/maven/listener/M2EMavenBuildDataBridge.java#L147 <https://github.com/eclipse-m2e/m2e-core/blob/052d41c96f8af79200213c9e0982d23e5e02164b/m2e-maven-runtime/org.eclipse.m2e.maven.runtime/src/main/java/org/eclipse/m2e/internal/maven/listener/M2EMavenBuildDataBridge.java#L147>
(Path.of is only available in JRA11+)
On 25. Nov 2022, at 10:38, Christoph Läubrich <laeubi@xxxxxxxxxxxxxx
<mailto:laeubi@xxxxxxxxxxxxxx>> wrote:
Maven runtime can use the minimal version of maven and its
dependencies (1.8) but m2e requires Java 17 to run...
Am 25.11.22 um 10:35 schrieb Konrad Windszus:
When I follow these steps, the Eclipse Project
“org.eclipse.m2e.maven.runtime” is imported with JRE 1.8 (due the
m-compiler-p configuration in
https://github.com/eclipse-m2e/m2e-core/blob/master/m2e-maven-runtime/pom.xml#L85 <https://github.com/eclipse-m2e/m2e-core/blob/master/m2e-maven-runtime/pom.xml#L85>), but in fact JRE 11 is used (e.g. in https://github.com/eclipse-m2e/m2e-core/blob/052d41c96f8af79200213c9e0982d23e5e02164b/m2e-maven-runtime/org.eclipse.m2e.maven.runtime/src/main/java/org/eclipse/m2e/internal/maven/listener/M2EMavenBuildDataBridge.java#L147 <https://github.com/eclipse-m2e/m2e-core/blob/052d41c96f8af79200213c9e0982d23e5e02164b/m2e-maven-runtime/org.eclipse.m2e.maven.runtime/src/main/java/org/eclipse/m2e/internal/maven/listener/M2EMavenBuildDataBridge.java#L147>).
Something seems to be off here…
Can you clarify the minimum JRE for Maven Runtime?
Konrad
On 20. Nov 2022, at 21:08, Hannes Wellmann <wellmann.hannes1@xxxxxxx
<mailto:wellmann.hannes1@xxxxxxx>> wrote:
Hello M2E-Devs,
the maven-runtime projects of M2E that provide the embedded Maven
runtime and archetype have been reworked to be Maven projects [1],
that also participate in the regular PDE workspace build when being
checked out in the M2E-dev workspace.
This conversion simplifies the build of M2E to a single 'mvn clean
verify' invocation and also allows to add extra custom M2E classes
to the embedded maven runtime, while keeping the simplicity of
maven/archetype version updates.
The reason I'm reaching out to you is that, when you update your
existing M2E workspace to the current master there will likely some
garbage in the unstaged area in the "Git Staging".
In order to clean up your m2e-maven-runtime project and its
sub-projects I recommend you to perform the following steps:
1. Delete the project "m2e-maven-runtime" and its two nested
children from your workspace (don't delete it from disk)
2. Perform a git-clean of the just delete project using the
following command from root of your m2e git repo clone:
git clean -x -f m2e-maven-runtime
3. Re-run the Oomph Setup for M2E and perform a restart, if necessary.
If you are not using the Oomph-setup, make sure you have the
latest m2e-snapshot installed in your development Eclipse and then
import "m2e-maven-runtime" and its two children as Existing Maven
projects as well as the new 'm2e-parent' project.
Greetings
Hannes
[1] - https://github.com/eclipse-m2e/m2e-core/pull/466
<https://github.com/eclipse-m2e/m2e-core/pull/466>
_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/m2e-dev
_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/m2e-dev
_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx <mailto:m2e-dev@xxxxxxxxxxx>
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/m2e-dev
_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/m2e-dev
