Re: [m2e-dev] Change in Maven Parent resolution

[Mickael Istria <mistria@xxxxxxxxxx>]

Hi Robert, Hi all,

As discussed at FOSDEM, I submitted a Gerrit review to use Maven
3.7.0-SNAPSHOT at https://git.eclipse.org/r/157023 and let the CI run
tests against it, and it's all green:
https://ci.eclipse.org/m2e/job/m2e-gerrit/588/

So your change seem fine from m2e point of view.

Feel free to ping on the mailing-list or the Gerrit review if you'd
like m2e to run tests against newer snapshots.

Cheers

On 1/31/20, Robert Scholte <rfscholte@xxxxxxxxxx> wrote:
> Hi Mickael,
>
> I've extended the ReactorModelCache with new methods. Handling the cache
> hasn't changed, so it is should keep the original behavior.
> One of our integration-tests was written for respecting file changes, this
> one still succeeds.
>
> Regarding the WorkspaceModelResolver, that was an assumption. I've always
> understood that this is the way M2E integrates with Maven.
>
> thanks,
> Robert
>
> On 31-1-2020 14:48:26, Mickael Istria <mistria@xxxxxxxxxx> wrote:
> _______________________________________________ m2e-dev mailing list
> m2e-dev@xxxxxxxxxxx To change your delivery options, retrieve your password,
> or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/m2e-dev
> Hi Robert,
>
> Thanks for sharing.
> Is the cache properly invalidated when the file changes on filesystem?
>
>> org.apache.maven.model.resolution.WorkspaceModelResolver. [...] As far as
>> I know M2E contains an implementation for this interface
>
> I couldn't find any reference to that interface in m2e code base. Did you
> identify more precisely where this may be used/extended?
>
> Cheers,
>


-- 
Mickael Istria
Eclipse IDE <https://www.eclipse.org/downloads/eclipse-packages/>
developer, for Red Hat Developers <https://developers.redhat.com/>