Hi,
I was wondering if:
a) the export of this repackaged dependency is really needed
I don't know. Best thing to try is probably to remove it and see whether it breaks something. You can push a patch to Gerrit and it will test everything.
But it could be that m2e uses some Guice classes to tweak the embedded Maven at runtime, and we shouldn't have m2e using a different Guice than the embedded one for that, or we'll have some "ClassCastException: com.google.inject.Blah cannot be cast to com.google.inject.Blah".
b) or the repackaging could be removed and and replaced with a
dependency on google.inject from Orbit
Nope. m2e ships a Maven "embedder" as produced, packaged and tested by the Maven project. At the moment, m2e doesn't have the resource to build and test different packages (using different version of this or that library) of Maven; and the internal Maven instance may also be used in a separate "flat classpath" mode when forking some executions.
Changing this would be a huge effort and will introduce a lot of risk in m2e.
HTH
