Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [m2e-dev] Maven classloader change
Thanks Igor for explaining.
Would you (or Fred) like to add this feedback to the Maven 3.5.1 vote thread, or do you want me to follow up saying the m2e team will handle this change?

/Anders

On Fri, Sep 15, 2017 at 2:07 PM, Igor Fedorenko <igor@xxxxxxxxxxxxxx> wrote:
Yeah, this is a result of MNG-6275. m2e includes entire maven runtime, including classworlds and plexus-utils and everything else, into a single OSGi bundle and that bundle now becomes parent of plugin classloaders created by Maven. This changes plugin classpath in two important ways. 1) it forces plugins to use m2e-embedded versions libraries maven internal libraries and 2) and exposes previously hidden m2e-embedded libraries (like guava or okhttp and few more) to the plugins.

While this is unfortunate, I believe it will be relatively easy to compensate for this in m2e, we just need to move classworlds to a separate bundle and everything should get back to normal.

--
Regards,
Igor


On Fri, Sep 15, 2017, at 07:42 AM, Anders Hammar wrote:
On Fri, Sep 15, 2017 at 1:36 PM, Igor Fedorenko <igor@xxxxxxxxxxxxxx> wrote:

When you say "jaxws-maven-plugin is using a different plexus-utils", do you mean run-as-maven-build or plugin execution during eclipse workspace build?

I mean plugin execution during eclipse workspace build. Haven't changed run-as-maven-build.

/Anders
 


--
Regards,
Igor


On Fri, Sep 15, 2017, at 04:33 AM, Anders Hammar wrote:

It looks like jaxws-maven-plugin is using a different plexus-utils than the one declared in the pom for jaxws-maven-plugin. Not sure that's the problem, but it's surprises me. Is that expected behavior or something that changed with Maven 3.5.1?

To clarify:
With Maven 3.5.1 on CLI, jaxws-maven-plugin uses plexus-utils as declared in it's pom (i.e. v3.0.22 for jaxws-m-p v2.5).
With m2e updated with embedded Maven 3.5.1, jaxws-maven-plugin uses a different version of plexus-utils than the one declared in it's pom. It seems to be v3.1.0 which happens to be the version of plexus-utils included in Maven 3.5.1.

This difference in behavior is not good I think as it could cause different behavior in m2e than on CLI. Is it the intended behavior or is it the MNG-6275 [1] change that causes this in m2e?

Please note that this specific library difference might not be the root cause for the jaxws-m-p issue.

Please note that we need to respond to the vote before 13:00 UTC if m2e is having a problem with the class loader change.


/Anders

 


/Anders


On Fri, Sep 15, 2017 at 9:24 AM, Anders Hammar <anders@xxxxxxxxxx> wrote:

On Fri, Sep 15, 2017 at 9:14 AM, Thorsten Heit <thorsten.heit@xxxxxx> wrote:

Hi Fred,


> That doesn't look like an m2e issue. Did it work before you installed m2e 1.9.0?
> I can't repro on Oxygen Java EE.
>
> Please try on a clean Eclipse install.


Indeed, with a vanilla Eclipse Oxygen JEE installation (via Eclipse installer) this works.
Obviously there are some changes between 4.7.0 and the upcoming 4.7.1 that will cause this (mis-?)behaviour in m2e 1.9.0...



This is strange. I'm seeing the issue with a clean Eclipse 4.7.0 (Java developer packaging installed with Eclipse Installer) which I just update with m2e 1.9.0 build with Maven 3.5.1 embedded.


/Anders


 



Regards


Thorsten


_______________________________________________
m2e-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit


_______________________________________________
m2e-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit


_______________________________________________
m2e-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
_______________________________________________
m2e-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit


_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/m2e-dev

Back to the top