Re: [m2e-dev] JDTCompilationParticipant

[Fred Bricon <fbricon@xxxxxxxxx>]

I still have one regression to fix (on webresource filtering, which is not even released in 0.12 yet) on m2eclipse-wtp, then I'll push a 0.13 branch on github (tonight, hopefully)
You'll have to build it by yourself, since we won't have a CI job ready before some time.

regards,

Fred Bricon

On Wed, Jan 26, 2011 at 3:22 PM, Igor Fedorenko <igor@xxxxxxxxxxxxxx> wrote:

Hmm, indeed, forgot about that. Custom lifecycle mapping like [1] is the
only way to make this work in 0.12.x. Or use 0.13. I believe Fred is
working on updated m2e-wtp and hopes to have a build ready soon.

[1] https://docs.sonatype.org/pages/viewpage.action?pageId=2949459

On 11-01-26 08:08 AM, Laurent RUAUD wrote:

I have it used in GenericBuildParticipant:
  private boolean getRequireFullBuild(IMavenProjectFacade
projectFacade) throws CoreException {
    if(projectFacade.getResolverConfiguration().isSkipCompiler()) {
      // see MNGECLIPSE-823
      return projectFacade.getProject().getSessionProperty(IMavenConstants.FULL_MAVEN_BUILD)
!= null;
    }
    return false;
  }

While JDTCompilationParticipant calls:
  public void requestFullMavenBuild(IProject project) throws CoreException {
    project.setSessionProperty(IMavenConstants.FULL_MAVEN_BUILD, Boolean.TRUE);
  }

Removing JDTCompilationParticipant solves my looping builds; though it
does not mean it is the cause of my issue.
But it certainly contributes to it.

Regards.
--
Laurent



2011/1/26 Igor Fedorenko<igor@xxxxxxxxxxxxxx>:

Even though JDTCompilationParticipant is present m2e 0.12.x, it does not
do anything, i.e. requireFullBuild is not used anywhere.
JDTCompilationParticipant has been removed from 0.13. Something else
triggers full rebuild and/or restarts the build.

--
Regards,
Igor

On 11-01-26 06:04 AM, Laurent RUAUD wrote:

Hi.

I'm investigating on loop building issues using m2e-core and m2e-wtp
and I went to this class (JDTCompilationParticipant).
This class declares that Maven needs a full rebuild when a clean
operation is called (as a fix for MNGECLIPSE-823).

However, It seems that this behaviour may be the cause of my build
looping.
It sets the flag requireFullBuild to true and you'll see AUTO_BUILD
requireFullBuild in Maven console.
Actually, Eclipse sometimes seems to call a clean operation after a
build one (maybe because of dependent modules in WTP) and then, Maven
ask for a full rebuild, looping between clean and build operations.
This behaviour has been reported in MECLIPSEWTP-77 but investigations
are not easy as this does not occur each time.

Does anybody know if the JDTCompilationParticipant fix is still needed?
Would it be possible to make this fix less radical?

Thanks in advance.
--
Laurent
_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/m2e-dev

_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/m2e-dev

_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/m2e-dev

_______________________________________________
m2e-dev mailing list
m2e-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/m2e-dev

-- 
"Have you tried turning it off and on again" - The IT Crowd