Re: [m2e-dev] Contributing to the m2eclipse-subclipse plugin

[Spencer Uresk <suresk@xxxxxxxxx>]

Igor,

Thanks for the feedback.

I sent my CLA in earlier this evening.

Also, I've made the changes you suggested and believe the plugin is ready to be setup for integration builds. The changes are in my fork [1] on Github. Once you receive my CLA, do you want me to submit a pull request on Github or should I create JIRA ticket with a patch attached?

- Spencer

On Nov 23, 2010, at 8:23 PM, Igor Fedorenko wrote:

> Looks reasonable. One minor comment. Tycho can use either repositories
> with layout=2 or .target file to calculate project build target
> platform. Although it does not hurt, you don't need both.
> 
> The next step would be to tell Tycho to package a p2 repository with
> m2eclipse-subcplise and explain how to publish it to
> repository.sonatype.org. You can copy&paste from [1], but make sure to
> replace m2eclipse-wtp with m2eclipse-subclipse closer to the bottom of
> the file. You will also need assembly descriptor like [2].
> 
> We will also need signed CLA [3] before we can accept any contributions.
> 
> This is basically it... From there, I'll setup CI build and hopefully
> new m2eclipse-subclipse will become shortly after. Once you are
> comfortable with build quality I will help you tag and make proper
> release build and add it to m2e-extras update site.
> 
> 
> [1] https://github.com/sonatype/m2eclipse-wtp/blob/master/org.maven.ide.eclipse.wtp.feature/pom.xml
> [2] https://github.com/sonatype/m2eclipse-wtp/blob/master/org.maven.ide.eclipse.wtp.feature/src/main/assembly/assembly.xml
> [3] http://www.sonatype.org/SonatypeCLA.pdf
> 
> --
> Regards,
> Igor
> 
> 
> On 10-11-23 03:41 PM, Spencer Uresk wrote:
>> As I mentioned on the other list, I'm interested in helping maintain the
>> m2eclipse-subclipse plugin. We've been using it internally (in kind of a
>> hackish way) for over a month with 0.12 dev builds and have had no
>> problems. I also took a few minutes to review the code in the plugin (it
>> is pretty small) to check for uses of changed APIs and didn't find
>> anything. So, I'm fairly confident it will work and would like to get
>> some dev builds that are compatible with m2eclipse 0.12 for people to
>> try out.
>> 
>> I've forked m2eclipse-subclipse at Github and am working on updating the
>> build to make it compatible with m2eclipse 0.12. My fork is here:
>> 
>> https://github.com/suresk/m2eclipse-subclipse
>> 
>> Can I get a review of the work I've done so far? Also, what other steps
>> do I need to take to get a build setup for this?
>> 
>> Thanks,
>> 
>> - Spencer
>> 
>> 
>> 
>> _______________________________________________
>> m2e-dev mailing list
>> m2e-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/m2e-dev
> _______________________________________________
> m2e-dev mailing list
> m2e-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/m2e-dev