Re: [jsp-dev] Possible correction for `com.sun.ts.tests.jsp.spec.el.jsp.

[Scott Marlow <smarlow@xxxxxxxxxx>]

Please also review the potential fix made that can be viewed via 
https://github.com/eclipse-ee4j/jakartaee-tck/compare/master...gurunrao:jsp-fix

Please give your +1 or -1 for that change on this mailing list of 
directly on the  [1] issue.

We will merge the 
https://github.com/eclipse-ee4j/jakartaee-tck/compare/master...gurunrao:jsp-fix 
change on Monday October 5, 2020 if we don't hear feedback.

Thanks,
Scott

On 10/1/20 10:02 AM, Scott Marlow wrote:
> On 9/30/20 1:04 PM, Scott Marlow wrote:
> > Hi,
> >
> > Could someone from the Jakarta Server Pages team please comment on 
> > jakartaee-tck/issues/535 [1] which is suggesting a change to test.
> >
> > The reported issue is a result of recent change jakartaee-tck/pull/349 
> > [2] that introduced the implementation specific change.  Does the 
> > Jakarta Server Pages team agree that the [2] change is invalid and 
> > should be updated?
> >
> > Does the Server Pages team you agree with the suggested change to 
> > `out.println(poundExpr.getExpressionString())`?
>
> I meant to ask if anyone from the Jakarta Server Pages team can explain 
> if the original intent of the tests/jsp/spec/el/jsp/ELJspVersionTag.java 
> [3] file is correctly maintained by both the jakartaee-tck/pull/349 [2] 
> pull request that was merged and the suggested modification mentioned in 
> jakartaee-tck/issues/535 [1]?
>
> I see [1] as sort of a challenge that we need to respond to by taking 
> action with consent of a representative of the jsp-dev@xxxxxxxxxxx 
> community (which can be anyone subscribed to jsp-dev@xxxxxxxxxxx).
>
> This question does sort of cross over Jakarta Expression Language but I 
> think the part of ValueExpression not being required to have a 
> toString() method is pretty clear from the Expression Language Javadoc.
>
> If I do not hear back soon (e.g. a few days), the Platform TCK team will 
> need to take some action to address [1].  It would be helpful if someone 
> from the team at least responds that they are not sure yet and need a 
> few days.
>
> Thanks,
> Scott
>
> > Scott
> >
> > [1] https://github.com/eclipse-ee4j/jakartaee-tck/issues/535
> > [2] https://github.com/eclipse-ee4j/jakartaee-tck/pull/349
> [3] 
> https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/jsp/spec/el/jsp/ELJspVersionTag.java