Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jsp-dev] What version should be specified for maven-compiler-plugin?

Looking over the project a bit more closely I think what you have laid out makes sense.

As a start I created the following PR and added you as a reviewer to update to 1.8 [1]

We can make more updates/corrects as we work through everything. I believe you're right we can probably eventually do  away with the project specific parent-pom and update to the latest overall EE4J parent.

Regards,

Paul Nicolucci


[1] https://github.com/eclipse-ee4j/jsp-api/pull/132

On Fri, Jan 24, 2020 at 5:14 AM Mark Thomas <markt@xxxxxxxxxx> wrote:
+1 on the move to 1.8. The code might not strictly need 1.8 but it may
allow some small improvements and there is no benefit to remaining
compatible with 1.7 as I don't see any possibility of a Jakarta EE 9
implementation running on Java 7.

The POMs look like they need some work. I'm not particularly familiar
with Maven. Are you?

There is the overall EE4J parent and the POMs for the API and the impl
use directly. Then there is the POM for the spec that references the POM
in parent-pom which in turn references the EE4J parent. And then there
is the POM in the top-level directory.

Looking at all of this my guess is as follows:

- the top level POM is intended to help build all 3 modules (API, impl,
  spec) but not to act as a parent for them
- each module should reference the latest EE4J parent
- parent-pom is unnecessary

Am I even close to understanding this correctly?

I'm involved in 4 projects and each has a slightly different structure.
it would be great to get a clear picture of how the POMs are meant to
work and then all four projects aligned.

Mark



On 24/01/2020 05:01, Paul Nicolucci wrote:
> <mailto:jsp-dev@xxxxxxxxxxx>
> Hi,
>
> I was looking over the Release Plan and I see that it states Java SE 8
> should be used for the APIs 
> https://eclipse-ee4j.github.io/jakartaee-platform/jakartaee9/JakartaEE9ReleasePlan
>
> It looks like the api [1] and impl [2] specify 1.7
>
> I'm not familiar with how the parent pom [3] is used but that specifies
> 1.5 in the maven-compiler-plugin.
>
> Should we move some or all of these to 1.8?
>
> Thanks,
>
> Paul Nicolucci
>
> [1] https://github.com/eclipse-ee4j/jsp-api/blob/master/api/pom.xml
> [2] https://github.com/eclipse-ee4j/jsp-api/blob/master/impl/pom.xml
> [3] https://github.com/eclipse-ee4j/jsp-api/blob/master/parent-pom/pom.xml
>
> _______________________________________________
> jsp-dev mailing list
> jsp-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/jsp-dev
>
_______________________________________________
jsp-dev mailing list
jsp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jsp-dev

Back to the top