After hearing about releng using JDK 11 as a standard, I am thinking we should let our
main gerrit mimic that. I have configured the eclipse.jdt.core-Gerrit to JDK 11.0.4.
>Again: let me know if we need to test on 14 outside of
>compiler.regression tests.
I understand the tests in Javac comparision mode take bit longer to complete. So, perhaps
they are better run only for the relevant tests.
>I propose this setup:
>Triggered by gerrit:
>- eclipse.jdt.core-Gerrit to run on 11
>Time-triggered:
>- eclipse.jdt.core-run.javac-1.8 (last pre JPMS)
>- eclipse.jdt.core-run.javac-11 (current LTS)
>- eclipse.jdt.core-run.javac-14 (latest)
Sounds good to me.
Apart from these, we also have two jobs for beta branches. For e.g. as of now,
we have one for Java 14 and one for Java 15. The latter can be configured to use JDK 15 (it
already uses the same for tests).
Regards,
Jay
-----jdt-dev-bounces@xxxxxxxxxxx wrote: -----
>To: jdt-dev@xxxxxxxxxxx
>From: Stephan Herrmann
>Sent by: jdt-dev-bounces@xxxxxxxxxxx
>Date: 05/18/2020 09:14PM
>Subject: [EXTERNAL] Re: [jdt-dev] Changes to JDT Core gerrit
>
>On 18.05.20 16:48, Jayaprakash Arthanareeswaran wrote:
>> We already have one for JDT core off master and one two for the
>BETA branches
>> and now I just learnt from Stephan that we have one more.
>
>I'm pretty sure you have heard about it, maybe you just didn't
>recognize it :)
>
>It's actually a set of 3 similar jobs running the back-to-back
>comparison vs.
>javac (version 1.8, 10 and 12 currently). Those run over the weekend
>from
>master, not from gerrit. See https://bugs.eclipse.org/404648
>
>
>
>> Unless there's a compelling reason to keep using JDK 8 for the main
>one, we
>> should upgrade then and as Stephan said, it can even be 14, to
>> better match our dev environment.
>
>I propose this setup:
>Triggered by gerrit:
>- eclipse.jdt.core-Gerrit to run on 11
>Time-triggered:
>- eclipse.jdt.core-run.javac-1.8 (last pre JPMS)
>- eclipse.jdt.core-run.javac-11 (current LTS)
>- eclipse.jdt.core-run.javac-14 (latest)
>
>There's actually some inconsistency: while those run against the
>specified
>version of javac, they are running *on* these versions:
>- oracle-jdk8-latest
>- oracle-jdk8-latest
>- (System)
>I'm more than happy to align base JDK and javac version used in
>comparison.
>
>Again: let me know if we need to test on 14 outside of
>compiler.regression tests.
>
>WDYT?
>Stephan
>
>
>> -----jdt-dev-bounces@xxxxxxxxxxx
><mailto:-----jdt-dev-bounces@xxxxxxxxxxx>
>> wrote: -----
>> To: "Eclipse JDT general developers list." <jdt-dev@xxxxxxxxxxx
>> <mailto:jdt-dev@xxxxxxxxxxx>>
>> From: Jonah Graham
>> Sent by: jdt-dev-bounces@xxxxxxxxxxx
><mailto:jdt-dev-bounces@xxxxxxxxxxx>
>> Date: 05/18/2020 07:41PM
>> Subject: [EXTERNAL] Re: [jdt-dev] Changes to JDT Core gerrit
>>
>> If it helps, you can have multiple Gerrit CI jobs per patch set,
>one doing Java
>> 11, one doing Java 12.
>>
>> In CDT we use that to parallelize the tests and to not bother
>running tests that
>> are irrelevant.
>>
>> HTH,
>> Jonah
>>
>> On Mon., May 18, 2020, 09:44 Stephan Herrmann,
><stephan.herrmann@xxxxxxxxx
>> <mailto:stephan.herrmann@xxxxxxxxx>> wrote:
>>
>> We have an existing weekly job eclipse.jdt.core-run.javac-12.
>Would that help?
>> Currently it only covers the compiler regression suite, would
>you need other
>> tests covered?
>> Of course you could always manually trigger the job if needed,
>I'm just not
>> sure
>> it can pick up gerrit changes before merge.
>>
>> I was also thinking about upgrading that job to 14. WDYT?
>>
>> Stephan
>>
>> On 18.05.20 13:51, Jayaprakash Arthanareeswaran wrote:
>> > Well, I had a vested interested that wanted to make use some
>of the stuff
>> that
>> > comes with JDK 12. But that's not very important.
>> > If releng is standardizing on 11, I will try with 11.
>> >
>> > Just in case, how about moving to an even newer version for
>gerrits?
>> >
>> > Regards,
>> > Jay
>> >
>> > -----jdt-dev-bounces@xxxxxxxxxxx
><mailto:jdt-dev-bounces@xxxxxxxxxxx>
>> <mailto:-----jdt-dev-bounces@xxxxxxxxxxx
><mailto:jdt-dev-bounces@xxxxxxxxxxx>>
>> > wrote: -----
>> > To: "Eclipse JDT general developers list."
><jdt-dev@xxxxxxxxxxx
>> <mailto:jdt-dev@xxxxxxxxxxx>
>> > <mailto:jdt-dev@xxxxxxxxxxx <mailto:jdt-dev@xxxxxxxxxxx>>>
>> > From: Aleksandar Kurtakov
>> > Sent by: jdt-dev-bounces@xxxxxxxxxxx
><mailto:jdt-dev-bounces@xxxxxxxxxxx>
>> <mailto:jdt-dev-bounces@xxxxxxxxxxx
><mailto:jdt-dev-bounces@xxxxxxxxxxx>>
>> > Date: 05/18/2020 03:17PM
>> > Subject: [EXTERNAL] Re: [jdt-dev] Changes to JDT Core gerrit
>> >
>> >
>> >
>> > On Mon, May 18, 2020 at 12:06 PM Jayaprakash
>Arthanareeswaran
>> > <jarthana@xxxxxxxxxx <mailto:jarthana@xxxxxxxxxx>
>> <mailto:jarthana@xxxxxxxxxx <mailto:jarthana@xxxxxxxxxx>>>
>wrote:
>> >
>> > Hello,
>> >
>> > As an experiment, I am moving the jdt core gerrit [1] to
>open JDK 12
>> (as of
>> > now now it's still using jdk 8). The details on why this
>is being tried
>> > can be found on
>https://bugs.eclipse.org/bugs/show_bug.cgi?id=548999
>> >
>> >
>> > Why Java 12? Releng uses Java 11 for all builds now.
>> >
>> >
>> > Depending on how this goes, I will keep this change or
>revert it. If you
>> > have a reason why this (newer JDK) should not be used,
>please let me
>> know.
>> >
>> > Regards,
>> > Jay
>> >
>> > [1]
>https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Gerrit/
>> >
>> >
>> > _______________________________________________
>> > jdt-dev mailing list
>> > jdt-dev@xxxxxxxxxxx <mailto:jdt-dev@xxxxxxxxxxx>
>> <mailto:jdt-dev@xxxxxxxxxxx <mailto:jdt-dev@xxxxxxxxxxx>>
>> > To unsubscribe from this list, visit
>> > https://www.eclipse.org/mailman/listinfo/jdt-dev
>> >
>> >
>> >
>> > --
>> > Alexander Kurtakov
>> > Red Hat Eclipse Team
>> > _______________________________________________
>> > jdt-dev mailing list
>> > jdt-dev@xxxxxxxxxxx <mailto:jdt-dev@xxxxxxxxxxx>
>> <mailto:jdt-dev@xxxxxxxxxxx <mailto:jdt-dev@xxxxxxxxxxx>>
>> > To unsubscribe from this list, visit
>> > https://www.eclipse.org/mailman/listinfo/jdt-dev
>> >
>> >
>> > _______________________________________________
>> > jdt-dev mailing list
>> > jdt-dev@xxxxxxxxxxx <mailto:jdt-dev@xxxxxxxxxxx>
>> > To unsubscribe from this list, visit
>> https://www.eclipse.org/mailman/listinfo/jdt-dev
>> >
>>
>> _______________________________________________
>> jdt-dev mailing list
>> jdt-dev@xxxxxxxxxxx <mailto:jdt-dev@xxxxxxxxxxx>
>> To unsubscribe from this list, visit
>> https://www.eclipse.org/mailman/listinfo/jdt-dev
>>
>> _______________________________________________
>> jdt-dev mailing list
>> jdt-dev@xxxxxxxxxxx <mailto:jdt-dev@xxxxxxxxxxx>
>> To unsubscribe from this list, visit
>> https://www.eclipse.org/mailman/listinfo/jdt-dev
>>
>>
>> _______________________________________________
>> jdt-dev mailing list
>> jdt-dev@xxxxxxxxxxx
>> To unsubscribe from this list, visit
>https://www.eclipse.org/mailman/listinfo/jdt-dev
>>
>
>_______________________________________________
>jdt-dev mailing list
>jdt-dev@xxxxxxxxxxx
>To unsubscribe from this list, visit
>https://www.eclipse.org/mailman/listinfo/jdt-dev
>
