Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jaxrs-dev] [jakartaee-tck-dev] TCK Assertion Numbers


On 31/08/20 6:48 pm, Alwin Joseph wrote:

My understanding is that the tools used the pdf spec document to extract the xml. The pdf built from the https://github.com/eclipse-ee4j/authorization does have the "Requirements" numbered under section 1.4 from 1 to 10.

This was based on the https://github.com/eclipse-ee4j/jakartaee-tck-tools/tree/master/tools/extract-spec-assertions , might not be the same for authorization

I think that the items under "Requirements" are numbered which needs to be identified by the tool.

Regards,
-Alwin

On 29/08/20 2:29 pm, arjan tijms wrote:
Hi,

The tools seem fine for now, but shouldn't there be some markers or annotations present in the source spec document?

For example, take authorization, assertion 4:


<assertion required = "true" impl-spec = "false" defined-by = "technology" status = "active" testable = "true">
<id>4</id>
<description>
    Each Policy provider that satisfies this contract must perform or delegate to another provider 
    all the permission evaluations requested via its interface in the JRE; not just those made by the container to 
    implement Jakarta EE security functionality.
</description>     

Now in the spec document we have:


=== Requirements

. This contract must support providers that are unable to determine, before returning from `Policy.getPermissions()`, 
all the permissions that pertain to a subject/protection domain.

. Each Policy provider that satisfies this contract must perform or delegate to another provider all the permission
evaluations requested via its interface in the JRE; not just those made by the container to implement 
Jakarta EE security functionality.

. Each provider must export interfaces (defined by this contract) for use by containers and or container deployment
tools to create policy statements within the policy store of the provider. These interfaces must be used when an 
application or module is deployed in a container.

I think the assumption is that there's a marker, annotation or tag involving "4" around the second list item. But it's not there. Meaning, the tools can't extract that paragraph automatically and put it in an XML file with the ID 4.

Now I wonder, was the original document marked in some way and didn't this marking or tag transfer, or am I just totally missing something?

Kind regards,
Arjan













On Sat, Aug 29, 2020 at 7:29 AM Alwin Joseph <alwin.joseph@xxxxxxxxxx> wrote:

Hi,

Different specs were probably using different tools to generate xml & the corresponding htmls. I  checked with @jansupol and adding some info on generating the assertion files that was followed.

1. For generation of the xml files from the api jar, https://github.com/eclipse-ee4j/jakartaee-tck-tools/tree/master/tools/scripts assert-gen.sh could be used.
2. Then you merge it with existing xml assertion list using https://github.com/eclipse-ee4j/jakartaee-tck-tools/tree/master/tools/assert-merge or https://github.com/eclipse-ee4j/jakartaee-tck-tools/tree/master/tools/assert-merge-edited.
3. build html with https://github.com/eclipse-ee4j/jakartaee-tck-tools/tree/master/tools/scripts assert-num-api2-html.sh
4. Use https://github.com/eclipse-ee4j/jakartaee-tck-tools/tree/master/tools/legacy-assert to compute the code coverage xmls
5. run https://github.com/eclipse-ee4j/jakartaee-tck-tools/tree/master/tools/assertion-coverage to generate html from the coverage xml.


For platform spec, we did use the steps in https://github.com/eclipse-ee4j/jakartaee-tck/wiki/Steps-to-generate-the-html-version-of-the-SpecAssertions.xml for generating the html version of assertion xmls, instead of the step 3 above.


Earlier the jakartaee-tck/internal/docs folder had the original assertion files generated but since this directory was not added to the tck bundle, the required documents were copied over to install/ folder. I think it is safe to remove the ones in jakartaee-tck/internal/docs/{tck}/ if there is a duplicate copy in jakartaee-tck/install/{tck}/docs/.

Regards,
Alwin


On 29/08/20 6:37 am, Ed Bratt wrote:

(+jakartaee-tck-dev since that's where these ought to be found)

Arjan

I'll look into this. I don't think these are included in the final TCKs. While we might be able to dredge these up, I'm hoping their absence won't delay any of the Jakarta EE 9 ballots.

-- Ed

On 8/28/2020 10:35 AM, arjan tijms wrote:


On Fri, Aug 28, 2020 at 6:55 PM Ed Bratt <ed.bratt@xxxxxxxxxx> wrote:

You may find these references helpful:

Very roughly, the process (and it is not even remotely error-free, nor fully automated):

  1. Extract spec assertions from pdf spec docs as xml using  https://github.com/eclipse-ee4j/jakartaee-tck-tools/tree/master/tools/extract-spec-assertions

Maybe those assertions have been lost in the transfer process? I could be missing something, but I don't see them anymore in e.g. the Authentication, Authorization, Standard Tags, spec docs.

Kind regards,
Arjan




_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev__;!!GqivPVa7Brio!P2VY7pTjv1Jz917BNvB0qBrVlymJ-gjlk-NQKshqZ1J9oj5UggsSqChqI8f66wYUjg$

Back to the top