| Re: [jaxrs-dev] Checkstyle Settings / Code Format Conventions |
I need to say, since aleays I am using 160 chars and final everywhere by convention (Eclipse does that for me automatically), so this is pretty fine and familiar to me. Also, this is not just "some" code, this is an API spec, and I think it would be good that the API is "as final [in the sense of 'pretty clear'] as it can" if you know what I mean. ;-) Others chime in! We need more opinions! :-) -Markus From: jaxrs-dev-bounces@xxxxxxxxxxx [mailto:jaxrs-dev-bounces@xxxxxxxxxxx] On Behalf Of arjan tijms Hi, 160 chars IMHO is good to have as “exception”, meaning devs should normally strive to have less chars on a line (like 120, or even less), but occasionally using up to 169 when really needed is okay.160+ would almost always be too much. Final params everywhere is technically quite nice, but also very noisy and it’s by far not generally applied in other projects. Code with these *everywhere* feels slightly foreign. So I think it’s therefore better not to have these. My 2 cents ;) Kind regards, Arjan Tijms Hi all, basically I was trying to address issue #587 which is about the 984 Checkstyle errors we are getting with the current configuration. My idea was to remove the rules which are violated _very_ often, because in this case they are most likely trying to enforce a coding style, which the original authors of the code didn't _want_ to follow. Therefore, it doesn't make any sense to enforce them, especially because they are hiding the real issues. First of all, the number of violations actually increases to 2,515 after updating the checkstyle-maven-plugin to the latest release, so actually this is the number we are starting from. The Checkstyle rules I adjusted/removedare the following:
Let me know what you think. I'll create a pull request for the Checkstyle update at the weekend followed by individual pull requests for the config file adjustments if we agree on these changes. Christian 2018-02-23 19:05 GMT+01:00 Markus KARG <markus@xxxxxxxxxxxxxxx>: Hello Fellow Committers, Christian noticed that the Checkstyle settings are different from the actual Code formatting, so many files fail this check. It would be good if we find a concensus about the actually wanted style and then either fix the files, or fix the checkstyle config. For example: Line lenght is set to 120 but some files are 160. Christian, maybe you can chime in here and propose the wanted changes in detail. :-) You comments please! :-) -Markus
-- |