Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jaxrs-dev] PR Review Voting: Comments to Github Tool?

+1 for B

On Fri, Feb 23, 2018 at 12:11 PM Christian Kaltepoth <christian@xxxxxxxxxxxx> wrote:
I really like (B), And as we plan to mostly use pull requests to get changes into the repository, this would be a very good fit.

2018-02-23 18:59 GMT+01:00 Markus KARG <markus@xxxxxxxxxxxxxxx>:

Hello Fellow Committers,

 

apparently we use different voting style for PRs, which makes it a bit hard for the assignee of a PR to count the actual votes. It would be good if we could agree on using one single voting style:

 

(A) "+1", "0", "-1" text comments in the PR?

 

(B) Using the Github Review Tool which exists for exactly this?

 

(C) Something different?

 

My personal vote would be (B) as we use Github, so why not using that solution?

 

Christian seems to like (B), also.

 

What do YOU think?

-Markus


_______________________________________________
jaxrs-dev mailing list
jaxrs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jaxrs-dev




_______________________________________________
jaxrs-dev mailing list
jaxrs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jaxrs-dev

Back to the top