Re: [january-dev] I found two circular dependencies

[Matthew Webber <matthew@xxxxxxxxxxxxxx>]

I don't see this problem. I will continue to look at it, but I suspect it's a non-issue.

On 11 November 2016 at 11:13, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:

There is also this dep in the tree that does not look right:

org.eclipse.january.asserts -> uk.ac.gda.nexus.test

Jonah



~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com


On 11 November 2016 at 10:13,  <Peter.Chang@xxxxxxxxxxxxx> wrote:
>
>
> Is it broken? The january.test is a fragment.
>
>
>
> Peter
>
>
>
>
>
> From: january-dev-bounces@eclipse.org
> [mailto:january-dev-bounces@eclipse.org] On Behalf Of
> Matt.Gerring@xxxxxxxxxxxxx
> Sent: 11 November 2016 10:02
> To: january-dev@xxxxxxxxxxx
> Subject: [january-dev] FW: I found two circular dependencies
>
>
>
> Could somebody fix this please? J
>
>
>
> From: Ralphs, Keith (DLSLtd,RAL,LSCI)
> Sent: 11 November 2016 10:01
> To: Gerring, Matt (DLSLtd,RAL,LSCI)
> Subject: RE: I found two circular dependencies
>
>
>
> This appears to be because january depends on january.test which depends on
> january. Maybe we should use February instead?
>
>
>
> Seriously, there should be no test code in the uk.ac.diamond.daq.server.site
> dependency tree (or any other ‘product’s in my opinion). I spent quite a bit
> of time removing it when GDA9 server was originally put together and I don’t
> want any creeping back in.
>
>
>
> Keith
>
>
>
> From: Gerring, Matt (DLSLtd,RAL,LSCI)
> Sent: 11 November 2016 09:44
> To: Ralphs, Keith (DLSLtd,RAL,LSCI)
> Cc: Mudd, James (DLSLtd,RAL,LSCI)
> Subject: I found two circular dependencies
>
>
>
> Circular component dependency detected. Chain is
> uk.ac.diamond.daq.beamline.p45.site ->
> uk.ac.diamond.daq.beamline.p45.feature ->
> uk.ac.diamond.daq.mapping.ui.feature ->
> org.eclipse.dawnsci.remotedataset.feature -> org.eclipse.dawnsci.json ->
> org.eclipse.dawnsci.json.test -> org.eclipse.dawnsci.analysis.dataset ->
> org.eclipse.january -> org.eclipse.january.test ->
> org.eclipse.dawnsci.remotedataset.server -> org.eclipse.dawnsci.plotting.api
> -> org.eclipse.dawnsci.analysis.api -> org.eclipse.dawnsci.analysis.examples
> -> org.eclipse.dawnsci.analysis.tree ->
> org.eclipse.dawnsci.remotedataset.test -> org.eclipse.dawnsci.json ->
> org.eclipse.dawnsci.analysis.api -> org.eclipse.dawnsci.analysis.examples ->
> org.eclipse.dawnsci.remotedataset.server ->
> org.eclipse.dawnsci.analysis.tree -> org.eclipse.dawnsci.nexus ->
> org.eclipse.dawnsci.nexus.test -> org.eclipse.dawnsci.hdf5 ->
> org.eclipse.dawnsci.hdf5.test -> org.eclipse.january.asserts ->
> org.eclipse.dawnsci.nexus -> org.eclipse.dawnsci.nexus.test ->
> org.eclipse.dawnsci.hdf5 -> uk.ac.diamond.daq.mapping.ui ->
> org.eclipse.scanning.event.ui -> org.eclipse.january
>
>
>
>
>
>
>
> Circular component dependency detected. Chain is
> uk.ac.diamond.daq.server.site -> uk.ac.diamond.daq.server.feature ->
> uk.ac.diamond.daq.server -> uk.ac.gda.core -> uk.ac.gda.api ->
> uk.ac.gda.nexus -> org.eclipse.dawnsci.analysis.tree ->
> org.eclipse.dawnsci.analysis.dataset -> org.eclipse.january ->
> org.eclipse.january.test -> org.eclipse.january.asserts ->
> uk.ac.gda.nexus.test -> uk.ac.gda.test.helpers -> org.eclipse.dawnsci.nexus
> -> org.eclipse.dawnsci.analysis.tree -> org.eclipse.dawnsci.nexus.test ->
> org.eclipse.dawnsci.hdf5 -> org.eclipse.dawnsci.hdf5.test ->
> org.eclipse.dawnsci.nexus -> org.eclipse.dawnsci.nexus.test ->
> org.eclipse.dawnsci.hdf5 -> org.eclipse.january
>
>
>
> Maybe we could use some DS to break these cycles??
>
>
>
> Matt
>