Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[ice-build] [eclipse/ice] 6d952a: Added copy, clone, equals, and hashcode methods (e... 
  Branch: refs/heads/jordan/bug465740
  Home:   https://github.com/eclipse/ice
  Commit: 6d952a7ae72e31d396c2c135e223970cca2e9f19
      https://github.com/eclipse/ice/commit/6d952a7ae72e31d396c2c135e223970cca2e9f19
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-04 (Mon, 04 May 2015)

  Changed paths:
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/ConnectionTable.java
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/KeyEntry.java
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/KeyEntryContentProvider.java
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/PortEntry.java
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/PortEntryContentProvider.java
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/SecretEntry.java

  Log Message:
  -----------
  Added copy, clone, equals, and hashcode methods (except for
ConnectionTable).

Signed-off-by: Jordan Deyton <jordan.deyton@xxxxxxxxx>


  Commit: 0a44024fcebdd2b02ddf0a0ae54dc6c91b5f5ebd
      https://github.com/eclipse/ice/commit/0a44024fcebdd2b02ddf0a0ae54dc6c91b5f5ebd
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-04 (Mon, 04 May 2015)

  Changed paths:
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/SimpleCountKeyManager.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/SimpleDiscreteKeyManager.java

  Log Message:
  -----------
  Added IKeyChangeListeners to these test classes.

Signed-off-by: Jordan Deyton <jordan.deyton@xxxxxxxxx>


  Commit: 640e602f920a1dbd38d7497174ebfa8b45ac0645
      https://github.com/eclipse/ice/commit/640e602f920a1dbd38d7497174ebfa8b45ac0645
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-04 (Mon, 04 May 2015)

  Changed paths:
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/IKeyChangeListener.java

  Log Message:
  -----------
  Updated some documentation for clarity.

Signed-off-by: Jordan Deyton <jordan.deyton@xxxxxxxxx>


  Commit: 34f24c72c603a7dfef6c76593a724a0779d1f586
      https://github.com/eclipse/ice/commit/34f24c72c603a7dfef6c76593a724a0779d1f586
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-04 (Mon, 04 May 2015)

  Changed paths:
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/KeyEntryContentProvider.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/KeyEntryContentProviderTester.java

  Log Message:
  -----------
  Updated the behavior of the KeyEntryContentProvider to automatically
update based on the associated IKeyManager instead of just passing the
requests to the IKeyManager. This is necessary so that its overridden
equals methods work properly with its parent class.

Signed-off-by: Jordan Deyton <jordan.deyton@xxxxxxxxx>


  Commit: 01d5d7b36370ca1c804457eaba410bb1f77f0ffb
      https://github.com/eclipse/ice/commit/01d5d7b36370ca1c804457eaba410bb1f77f0ffb
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-04 (Mon, 04 May 2015)

  Changed paths:
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/KeyEntryContentProviderTester.java

  Log Message:
  -----------
  Added and implemented tests for equals, hashcode, clone, and copy.

Signed-off-by: Jordan Deyton <jordan.deyton@xxxxxxxxx>


  Commit: 0d67fc95279582ce2ddc6e78608abc7495088e24
      https://github.com/eclipse/ice/commit/0d67fc95279582ce2ddc6e78608abc7495088e24
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-05 (Tue, 05 May 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/DataComponentComposite.java
    M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/EntryComposite.java
    M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEDataComponentSectionPart.java
    M src/org.eclipse.ice.item/src/org/eclipse/ice/item/jobLauncher/JobLauncher.java
    M src/org.eclipse.ice.item/src/org/eclipse/ice/item/nuclear/MOOSELauncher.java

  Log Message:
  -----------
  Merge branch 'master' of https://github.com/eclipse/ice


  Commit: 3c1a23c3b3ecca55f2b90e21bcde7ec05f1b714a
      https://github.com/eclipse/ice/commit/3c1a23c3b3ecca55f2b90e21bcde7ec05f1b714a
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-05 (Tue, 05 May 2015)

  Changed paths:
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/KeyEntry.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/KeyEntryTester.java

  Log Message:
  -----------
  Added several more tests to KeyEntryTester and fixed some bugs and
formatting issues in KeyEntry.

Signed-off-by: Jordan Deyton <jordan.deyton@xxxxxxxxx>


  Commit: 30af2ab61f1658acaad829ec6d7eaae92a5dd067
      https://github.com/eclipse/ice/commit/30af2ab61f1658acaad829ec6d7eaae92a5dd067
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-06 (Wed, 06 May 2015)

  Changed paths:
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/KeyEntry.java
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/KeyEntryContentProvider.java
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/PortEntry.java
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/PortEntryContentProvider.java
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/SecretEntry.java

  Log Message:
  -----------
  Readability enhancements and documentation updates.

Overrode the second equals method in PortEntryContentProvider.

Signed-off-by: Jordan Deyton <jordan.deyton@xxxxxxxxx>


  Commit: 4155d0c5fd3c5a1941feebf8bfb5763d389d7ab3
      https://github.com/eclipse/ice/commit/4155d0c5fd3c5a1941feebf8bfb5763d389d7ab3
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-06 (Wed, 06 May 2015)

  Changed paths:
    R src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/Launcher.java

  Log Message:
  -----------
  Deleted this unnecessary class.

Signed-off-by: Jordan Deyton <jordan.deyton@xxxxxxxxx>


  Commit: eaadfd6ccf08f6fa9b12a87f2382c24661ad1708
      https://github.com/eclipse/ice/commit/eaadfd6ccf08f6fa9b12a87f2382c24661ad1708
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-06 (Wed, 06 May 2015)

  Changed paths:
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/connections/SecretEntry.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/KeyEntryContentProviderTester.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/KeyEntryTester.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/PortEntryContentProviderTester.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/PortEntryTester.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/SecretEntryTester.java

  Log Message:
  -----------
  Removed an unnecessary comment from SecretEntry.

Added missing tests to several of the test classes (e.g., checkEquals,
checkCopy).

Updated all checkEquals methods to be more comprehensive. All
checkEquals tests pass!

Signed-off-by: Jordan Deyton <jordan.deyton@xxxxxxxxx>


  Commit: 9e0865c5477bf7a726a3ab61f8f8f1cd63fd39ba
      https://github.com/eclipse/ice/commit/9e0865c5477bf7a726a3ab61f8f8f1cd63fd39ba
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-06 (Wed, 06 May 2015)

  Changed paths:
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/KeyEntryContentProviderTester.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/KeyEntryTester.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/PortEntryContentProviderTester.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/PortEntryTester.java
    M tests/org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/test/SecretEntryTester.java

  Log Message:
  -----------
  Implemented remaining tests.

Signed-off-by: Jordan Deyton <jordan.deyton@xxxxxxxxx>


  Commit: e0f3c17e2df8256b1e0acb32dcb31f1fbd7e3310
      https://github.com/eclipse/ice/commit/e0f3c17e2df8256b1e0acb32dcb31f1fbd7e3310
  Author: Jordan Deyton <jordan.deyton@xxxxxxxxx>
  Date:   2015-05-06 (Wed, 06 May 2015)

  Changed paths:
    M src/org.eclipse.ice.datastructures/src/org/eclipse/ice/datastructures/form/BasicEntryContentProvider.java
    M tests/org.eclipse.ice.datastructures.test/src/org/eclipse/ice/datastructures/test/BasicEntryContentProviderTester.java

  Log Message:
  -----------
  The BasicEntryContentProvider did not previously override the default
equals(Object) method.

I overrode the method and redirect it (if possible) to the standard
IEntryContentProvider.equals(...) method. I also added test code for
this.

Signed-off-by: Jordan Deyton <jordan.deyton@xxxxxxxxx>


Compare: https://github.com/eclipse/ice/compare/6d952a7ae72e^...e0f3c17e2df8

Back to the top