Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[ice-build] [eclipse/ice] d24476: Simplified the MOOSEFormEditor's interaction with ...

  Branch: refs/heads/master
  Home:   https://github.com/eclipse/ice
  Commit: d2447649ed64eff5beb5e652677700eea49ede1b
      https://github.com/eclipse/ice/commit/d2447649ed64eff5beb5e652677700eea49ede1b
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2014-12-17 (Wed, 17 Dec 2014)

  Changed paths:
    M src/org.eclipse.ice.client.widgets.moose/src/org/eclipse/ice/client/widgets/moose/MOOSEFormEditor.java
    M src/org.eclipse.ice.client.widgets.moose/src/org/eclipse/ice/client/widgets/moose/components/PlantBlockManager.java

  Log Message:
  -----------
  Simplified the MOOSEFormEditor's interaction with its PlantBlockManager,
which maps the "Components" block to a set of PlantComponents.

There was a lot of unnecessary work done that let the MOOSEFormEditor
listen to the MOOSE app selection in the MOOSETreeCompositeView.

Moved the code that creates the plant view to a couple of private
methods instead of an anonymous class inside addPlantPage(). On that
note, all of the additions to the plant view's ToolBar are done in the
private method fillPlantViewToolBar(ToolBarManager).

This fixes bug 455367 where the plant view renders empty until
components are unchecked and then checked again.

Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>


  Commit: e1b79709b676e88a104ca6a611a3222114c292ce
      https://github.com/eclipse/ice/commit/e1b79709b676e88a104ca6a611a3222114c292ce
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2015-01-06 (Tue, 06 Jan 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets.moose/src/org/eclipse/ice/client/widgets/moose/MOOSEFormEditor.java
    M src/org.eclipse.ice.client.widgets.moose/src/org/eclipse/ice/client/widgets/moose/components/PlantBlockManager.java

  Log Message:
  -----------
  Merge branch 'jordan/bug455367'

This fixes the issue where occasionally (or sometimes always) the MOOSE
Model Builder user has to manually uncheck and check all components to
get them to show up in the plant view.

Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>


Compare: https://github.com/eclipse/ice/compare/7bcf1922dd26...e1b79709b676

Back to the top