Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [hono-dev] Using Code Owners to assign reviewers automatically

So, let's see what we have then:

adapters/http-*                    Jens
adapters/mqtt-*                    Jens
adapters/amqp-*                    Kai
adapters/coap-*                    Kai
adapters/kura                      Kai
adapters/lora-*                    Kai
cli/                               Kai
client/                            Kai
core/                              Kai
deploy/src/main/deploy/openshift   Jens
deploy/*                           Dejan
example/                           Kai
jenkins/                           Kai
jmeter/                            Kai
service-base/                      Dejan
services/device-registry           Jens
services/*                         Dejan
site/                              Kai
tests/                             Kai

I think we can start with that. I will create the necessary config file and
create a PR for you to review.

Kai

On Wed, 2019-04-03 at 09:44 +0200, Jens Reimann wrote:
> I could focus on:
> 
> adapters/http-*
> adapters/mqtt-*
> deploy/src/main/deploy/openshift
> core
> services/device-registry
> 
> On Tue, Apr 2, 2019 at 10:45 AM Dejan Bosanac <dejanb@xxxxxxxxxxxx> wrote:
> > Hi Kai,
> > 
> > I could take
> > 
> > service-base/
> > services/
> > deploy/
> > 
> > modules for example. Let me know if that would work.
> > 
> > On Mon, Mar 18, 2019 at 1:57 PM Hudalla Kai (INST/ECS4) <
> > kai.hudalla@xxxxxxxxxxxx> wrote:
> > > Then what we now need is an initial partitioning of the code base with
> > > assignment
> > > to corresponding committers.
> > > 
> > > Any parts of the code or modules that you guys feel naturally responsible
> > > for or
> > > volunteer to be assigned to?
> > > 
> > > 
> > > On Tue, 2019-03-12 at 16:55 +0100, Dejan Bosanac wrote:
> > > > Sounds good
> > > > 
> > > > On Fri, Feb 22, 2019 at 8:55 AM Jens Reimann <jreimann@xxxxxxxxxx> wrote:
> > > > > +1
> > > > > 
> > > > > On Fri, Feb 22, 2019 at 8:45 AM Hudalla Kai (INST/ECS4) <
> > > > > kai.hudalla@xxxxxxxxxxxx> wrote:
> > > > > > Hi committers,
> > > > > > 
> > > > > > I have stumbled across this blog post from GitHub recently [1] and
> > > was
> > > > > > wondering
> > > > > > if we might want to introduce this to Hono as well. Given that we
> > > already
> > > > > > have
> > > > > > piled up some "inactive" committers which still show up in GitHub's
> > > > > > suggested
> > > > > > reviewers drop-down box, this might be a good approach to
> > > automatically
> > > > > > have
> > > > > > relevant people review PRs.
> > > > > > 
> > > > > > WDYT?
> > > > > > 
> > > > > > [1] https://github.blog/2017-07-06-introducing-code-owners/
> > > > > > 
> > > > > > -- 
> > > > > > Mit freundlichen Grüßen / Best regards
> > > > > > 
> > > > > > Kai Hudalla
> > > > > > Chief Software Architect
> > > > > > 
> > > > > > Bosch Software Innovations GmbH
> > > > > > Ullsteinstr. 128
> > > > > > 12109 Berlin
> > > > > > GERMANY
> > > > > > www.bosch-si.com
> > > > > > 
> > > > > > Registered Office: Berlin, Registration Court: Amtsgericht
> > > Charlottenburg;
> > > > > > HRB
> > > > > > 148411 B
> > > > > > Chairman of the Supervisory Board: Dr.-Ing. Thorsten Lücke; Managing
> > > > > > Directors:
> > > > > > Dr. Stefan Ferber, Michael Hahn, Dr. Aleksandar Mitrovic
> > > > > > 
> > > > > > _______________________________________________
> > > > > > hono-dev mailing list
> > > > > > hono-dev@xxxxxxxxxxx
> > > > > > To change your delivery options, retrieve your password, or
> > > unsubscribe
> > > > > > from this list, visit
> > > > > > https://www.eclipse.org/mailman/listinfo/hono-dev
> > > > > 
> > > > > 
> > > > > -- 
> > > > > Jens Reimann
> > > > > Principal Software Engineer / EMEA ENG Middleware
> > > > > Werner-von-Siemens-Ring 14
> > > > > 85630 Grasbrunn
> > > > > Germany
> > > > > phone: +49 89 2050 71286
> > > > >
> > > ___________________________________________________________________________
> > > __
> > > > > 
> > > > > Red Hat GmbH, www.de.redhat.com,
> > > > > Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen,
> > > HRB
> > > > > 153243,
> > > > > Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham,
> > > Michael
> > > > > O'Neill
> > > > > _______________________________________________
> > > > > hono-dev mailing list
> > > > > hono-dev@xxxxxxxxxxx
> > > > > To change your delivery options, retrieve your password, or unsubscribe
> > > from
> > > > > this list, visit
> > > > > https://www.eclipse.org/mailman/listinfo/hono-dev
> > > > 
> > > > 
> > > > _______________________________________________
> > > > hono-dev mailing list
> > > > hono-dev@xxxxxxxxxxx
> > > > To change your delivery options, retrieve your password, or unsubscribe
> > > from
> > > > this list, visit
> > > > https://www.eclipse.org/mailman/listinfo/hono-dev
> > > _______________________________________________
> > > hono-dev mailing list
> > > hono-dev@xxxxxxxxxxx
> > > To change your delivery options, retrieve your password, or unsubscribe
> > > from this list, visit
> > > https://www.eclipse.org/mailman/listinfo/hono-dev
> > 
> > 
> > -- 
> > Regards
> > --
> > Dejan Bosanac
> > http://sensatic.net/about
> > _______________________________________________
> > hono-dev mailing list
> > hono-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or unsubscribe from
> > this list, visit
> > https://www.eclipse.org/mailman/listinfo/hono-dev
> 
> 
> _______________________________________________
> hono-dev mailing list
> hono-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://www.eclipse.org/mailman/listinfo/hono-dev

Back to the top