Re: [gef-dev] Contributing e(fx)clipse 2.0 to simrel

[Alexander Nyßen <nyssen@xxxxxxxxx>]

Hi Tom,

I - however - only tested to run the runtime workspace with Java8 so far.

I now also performed some tests where I removed the package imports, and tried to launch the runtime workspace with Java7, leading to the following issues:

at org.eclipse.fx.osgi.fxloader.FXClassLoader.postFindClass(FXClassLoader.java:57)

at org.eclipse.osgi.internal.loader.BundleLoader.searchHooks(BundleLoader.java:455)

at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:419)

at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:352)

at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:344)

at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:160)

at java.lang.ClassLoader.loadClass(ClassLoader.java:412)

at java.lang.ClassLoader.loadClass(ClassLoader.java:358)

at org.eclipse.fx.osgi.fxloader.FXClassLoader.postFindClass(FXClassLoader.java:57)

Any ideas?

Cheers

Alexander

Am 10.04.2015 um 12:17 schrieb Alexander Nyßen <nyssen@xxxxxxxxx>:

Hi Tom,

yes, no objection from my side. I will then update our master to build against e(fx)clipse 2.0 as soon as you have promoted it to simrel. 

Cheers

Alexander

Am 10.04.2015 um 11:55 schrieb Tom Schindl <tom.schindl@xxxxxxxxxxxxxxx>:

Signierter PGP Teil

On 10.04.15 11:46, Alexander Nyßen wrote:
> Hi Tom,
>
>> Am 10.04.2015 um 11:00 schrieb Tom Schindl
>> <tom.schindl@xxxxxxxxxxxxxxx
>> <mailto:tom.schindl@xxxxxxxxxxxxxxx>>:
>>
>> Hi,
>>
>> It looks like there's a misunterstanding.
>>
>> You can NOT use -Dorg.osgi.framework.bundle.parent=ext but still
>> need to use the adapter hook because you need swtfx - so you
>> still require min.runtime.feature.
>
> I see, then this was indeed misunderstood.
>
>>
>> I think I made the changes in a way that you can as a first
>> experiment leave your code unchanged but only switch to version
>> 2.0 of the feature.
>
> I can confirm that switching to version 2.0 of the
> min.runtime.feature does not have a bad impact on GEF, i.e. with
> the package imports in place things still work as with 1.2.
>
>>
>> Once we are sure this works you can start removeing ALL javax
>> imports from your MANIFEST.MF and verify if things are still OK.
>
> Would you recommend to remove the imports and increase our version

I would do so because this remove the confusion that:
* you import version 2.2 although you are on Java8
* you don't import a package but things still compile which might be
  confusing to people.

It also has the advantage that if GEF4 runs in a pure OSGi+JavaFX env
that people don't require adapter hooks if they are not using the
SWT-integration.

> constraint for the min.runtime.feature to 2.0.0 at all? Does it
> have an impact on our transitive dependencies (up to now we still
> work with Java7 and JavaFX 2.2).

no - we still support 2.2 no impact for you!

I'd like to contribute our 2.0 version in the next few days to sim-rel
repo to fix copyright some problem reports from the sim-rel tools but
I guess this is ok for you now that we made sure things still operate
as before.

Tom

--
Thomas Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
http://www.bestsolution.at/
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck

_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/gef-dev

--
Dr. Alexander Nyßen
Dipl.-Inform.
Principal Engineer

Telefon: +49 (0) 231 / 98 60-202
Telefax: +49 (0) 231 / 98 60-211
Mobil: +49 (0) 151 /  17396743

http://www.itemis.de 
alexander.nyssen@xxxxxxxxx 

itemis AG
Am Brambusch 15-24
44536 Lünen

Rechtlicher Hinweis:

Amtsgericht Dortmund, HRB 20621

Vorstand: Jens Wagener (Vors.), Wolfgang Neuhaus, Dr. Georg Pietrek, Jens Trompeter, Sebastian Neus

Aufsichtsrat: Prof. Dr. Burkhard Igel (Vors.), Michael Neuhaus, Jennifer Fiorentino

--
Dr. Alexander Nyßen
Dipl.-Inform.
Principal Engineer

Telefon: +49 (0) 231 / 98 60-202
Telefax: +49 (0) 231 / 98 60-211
Mobil: +49 (0) 151 /  17396743

http://www.itemis.de 
alexander.nyssen@xxxxxxxxx 

itemis AG
Am Brambusch 15-24
44536 Lünen

Rechtlicher Hinweis:

Amtsgericht Dortmund, HRB 20621

Vorstand: Jens Wagener (Vors.), Wolfgang Neuhaus, Dr. Georg Pietrek, Jens Trompeter, Sebastian Neus

Aufsichtsrat: Prof. Dr. Burkhard Igel (Vors.), Michael Neuhaus, Jennifer Fiorentino

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail