[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [gef-dev] committing patches
|
Anthony,
As far as I know, the Eclipse legal process and the desire from the
community are two separate issues. The Eclipse legal process is used to
ensure that the code being contributed does not contain any patented
code and that the contributer has the copyright to contribute the work.
From what I have seen in my own work and other Eclipse projects, this
process is not necessary for small fixes. These should all be recorded,
the contributor given the appropriate acknowledgments and the committer
should ensure they have done their due diligence. For example, on Mylar
we have logged each one (http://www.eclipse.org/mylar/doc/mylar-iplog.csv).
As for community desire for a feature, this is something done on the bug
reports, etc... However, I think it would be absurd to think that
unless a bug report had X number of votes, it can't get in. If
something *changes API* or alters existing behaviour, then I agree, the
support of the community is necessary. But if we can provide additional
functionality without breaking backwards compatibility, then having a
large number of voters should not be needed (especially if others are
actually writing the patches).
The bug reports I am talking about are ones like:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=162779
That do have a code snippet that shows the problem as well as a patch
that fixes it.
Cheers,
Ian
Anthony Hunter wrote:
Hi Ian,
We will go though the outstanding bugs with patches in January. A note
on this however.
A patch on a feature needs to go through the Eclipse legal process for
contributions. https://bugs.eclipse.org/bugs/show_bug.cgi?id=71684 is
an example of a patch going through this process right now. We also
need to make sure that features are desired by the community. Bug
71684 is an example where there are a number of CC on the Bugzilla
clearly demonstrating the need for the feature.
With regards to patches on a bug report, it would be helpful if there
was a code snippit or JUnit test demonstrating the failing code.
Lastly with regards to your question regarding helping getting patches
in, this is the responsibility of the GEF committers. The process to
become a committer is
http://www.eclipse.org/membership/become_a_member/ and if your
employer is not a foundation member you can look at
http://www.eclipse.org/membership/become_a_member/committer.php
Cheers...
Anthony
--
Anthony Hunter mailto:anthonyh@xxxxxxxxxx
Manager: Eclipse GMF + GEF
IBM Rational Software: Aurora / Modeling Tools
Phone: 613-591-7037
*Ian Bull <irbull@xxxxxxxxx>*
Sent by: gef-dev-bounces@xxxxxxxxxxx
19/12/2006 12:13 AM
Please respond to
irbull@xxxxxxxxxx; Please respond to
GEF development <gef-dev@xxxxxxxxxxx>
To
gef-dev@xxxxxxxxxxx
cc
Subject
[gef-dev] committing patches
Hi all,
I was just going through some GEF/Draw2D bug reports and I noticed there
has only been 26 resolved bug reports since July 1st, and of this, only
5 were actual fixes (most were duplicates or invalid). Some of the
outstanding bugs even have patches attached. I understand that
priorities change and people get moved around to different projects, so
please don't think that I am pointing fingers. As a community member, I
was wondering if there was anything that can be done to help get patches
in? I am personally interested in Draw2D, but I imagine there are other
members who are interested in GEF too.
cheers,
Ian
_______________________________________________
gef-dev mailing list
gef-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/gef-dev