I did review the API (see the bug).
Are we talking about the same thing?
BTW, you did ask "if there are no objections"...
Jeff
On 2011-04-20, at 11:32 AM, Pascal Rapicault wrote: There is only one discussion point. Do we want a new class versus a setter? Rather than focusing on the process, please review the API. On 2011-04-20, at 11:30 AM, Jeff McAffer wrote: We seem to still be discussing the API. You seem to want to put it in now (today) and sort it out later. I'd like the API to be more "agreed to" before putting it in to M7 given the lateness of the hour.
Jeff
On 2011-04-20, at 10:43 AM, Pascal Rapicault wrote: The API has been ready since before eclipsecon. Dave and others reviewed it and it is good. What do you propose instead? We wait 3.7.1? On 2011-04-20, at 10:29 AM, Jeff McAffer wrote:
If there is no objection I will release that during the week so we can actually work on the code together.
I'm not a real fan of this approach in the last week of M7. If bogus API gets into M7 then we'll have a hell of a time removing/changing it. We almost always end up regretting those last minute pushes. For the code itself I don't care but releasing API that is not baked is less than optimal.
Jeff
On 2011-04-19, at 1:30 PM, Pascal Rapicault wrote: This issue has been discussed at the end of M6 with Tom and it has been agreed at the time that we will add this new API in M7 (I had not foreseen it happening so late).
I just attached a new patch taking the feedback into account. The focus is on API since this is the most pressing issue for the rest of the week. The code needs to be polished.
If there is no objection I will release that during the week so we can actually work on the code together.
On 2011-04-19, at 9:27 AM, Jeff McAffer wrote: That's new API right? I took a look but am not sure what the final form is that you are thinking of. Susan had some comments and David as well. The original patch from you had a method getAgent() which seems suspect as it does effectively the ServiceHelper trick. Do you have any examples of this API in use.
If you are going to look to release this please post a new patch with the proposed shape, some example use and mark for review. Ideally we could get John and/or DJ to review (I'll review as PMC guy). Please do not release until it has been reviewed.
Jeff
_______________________________________________ equinox-dev mailing list equinox-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/equinox-dev
_______________________________________________ equinox-dev mailing list equinox-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/equinox-dev
_______________________________________________ p2-dev mailing list p2-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/p2-dev
_______________________________________________ p2-dev mailing list p2-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/p2-dev
_______________________________________________ equinox-dev mailing list equinox-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/equinox-dev
_______________________________________________ p2-dev mailing list p2-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/p2-dev
|