Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [emfcp-dev] Compile errors in my workspace
Hi Christian, 

so I finally looked into the issue.

The error occurs, as we use package imports where ever we need classes from the org.eclipse.emf.edit.ui bundle.
The problem with this bundle is, that it relies on the org.eclipse.ui bundle. The org.eclipse.ui bundle then relies on the org.eclipse.ui.workbench and its Activator starts up the 3.x workbench.
What we did to support RAP in the j2ee mode (no workbench) and plain e4 applications, was to create a "org.eclipse.emf.rap.edit.ui.minimal" bundle.
This is basically a copy of the org.eclipse.emf.edit.ui bundle but without dependencies to org.eclipse.ui .

My understanding is that most of the time the eclipse compiler as well as tycho are satisfied if this bundle is opened. But from time to time eclipse shows compile errors.

We wanted to contribute this bundle to emf but Ed was never fond of it, as it is not possible to get it in without any breakages.
So our concrete suggestion was to create a "org.eclipse.emf.edit.ui.core" bundle without org.eclipse.ui dependencies and keep the current org.eclipse.emf.edit.ui bundle but let it extend the new bundle by providing classes with the org.eclipse.ui interfaces.

This would be basically transparent for the users, except for users with a bundle based run config, which would need to add the new bundle.

We're open for better suggestions.

Cheers,
Eugen


On Mon, Jan 29, 2018 at 3:30 PM, Eugen Neufeld <eneufeld@xxxxxxxxxxxxxxxxx> wrote:
Hi Christian and Mathias, 

I will look at this tomorrow.
I have a pretty good idea what the issue might be.

I will keep you posted.

Cheers,
Eugen

On Mon, Jan 29, 2018 at 9:45 AM, Mathias Hansen <mhansen@xxxxxxxxxxxxxxxxx> wrote:
Hi Christian,

I have the same problem right now, although I didn't look into it yet. So at least you are not the only one ;)

I'll talk to Eugen later today, he probably knows whats going on here.

Cheers!

Mat


On Sat, Jan 27, 2018 at 6:44 PM, Christian W. Damus <give.a.damus@xxxxxxxxx> wrote:
Hi, Team,

I raised a bug a while back to report compile errors in several of our source projects, owing to transitive dependencies on types that are not imported in those bundles:
  • org.eclipse.ui.views.properties.IPropertySourceProvider
  • org.eclipse.emf.ecp.edit.spi.swt.util.SWTValidationHelper
These are compile errors of the “type Xyz cannot be resolved. It is indirectly referenced from required .class files” sort.

I tried to fix this with a patch in Gerrit, but it fails to build with Tycho because Maven does not resolve the import of org.eclipse.ui.views.properties package.  Oddly, using the ECP target definition from the releng/org.eclipse.emf.ecp.target.rcp project, my workspace compiles just fine with this patch.  But of course, the patch is no good if Tycho can’t build it.  It’s a bit strange, too, that the Tycho build uses two target definition files (the ECP and RAP targets), which is a thing that PDE cannot do.  So, right off the top, our development environments are out of sync with the build.

So, my questions are
  1. How does everybody else not have these compile errors in their workspaces?  I have tried using other target definitions that I find in our git repo, but they are missing key components such as Mockito.
  2. Does anybody have a suggestion why the Tycho build would be unable to resolve the import of a package from a bundle that I quite definitely added to the target platform?  I even tried adding the entire org.eclipse.platform.feature.group, and with planner mode (the TP currently uses slicer) to ensure dependencies.
My set-up is 
  • based on Eclipse Modeling Tools EPP version Oxygen.2
  • configured by the EMFForms.setup Oomph set-up model in the repository
  • importing all of the ECP projects into my workspace, but
  • I close a large number of projects:  everything RAP-related, spreadsheet, emfstore, CDO, workspace, fx, graphiti, change broker, diff/merge, web (my focus is on some EMF Forms core stuff)
How do others on the team assemble their development environments for ECP/EMFForms?

Thanks,

Christian

_______________________________________________
emfcp-dev mailing list
emfcp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/emfcp-dev



--
Mathias Hansen

Software Engineer
EclipseSource Munich

Email: mhansen@eclipsesource.com
Web: http://eclipsesource.com/munich
Phone: +49 89 21 555 30 - 24
Mobile: +49 176 935 830 63
Fax: +49 89 21 555 30 - 19
Skype: mhansen_182

EclipseSource München GmbH
Agnes-Pockels-Bogen 1
80992 München

General Managers: Dr. Jonas Helming, Dr. Maximilian Kögel
Registered Office: Agnes-Pockels-Bogen 1, 80992 München,
Commercial Register München, HRB 191789

_______________________________________________
emfcp-dev mailing list
emfcp-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/emfcp-dev



--
Eugen Neufeld, M.Sc.

Software Engineer / Consultant
EclipseSource Munich

Email: eneufeld@eclipsesource.com
Web: http://eclipsesource.com/munich
Mobil: +49 176 22 85 11 50
Phone: +49 89 21 555 30 - 13
Fax: +49 89 21 555 30 - 19

EclipseSource Muenchen GmbH
Agnes-Pockels-Bogen 1
80992 Muenchen

General Managers: Dr. Jonas Helming, Dr. Maximilian Koegel
Registered Office: Agnes-Pockels-Bogen 1, 80992 Muenchen, Commercial Register Muenchen, HRB 191789



--
Eugen Neufeld, M.Sc.

Software Engineer / Consultant
EclipseSource Munich

Email: eneufeld@xxxxxxxxxxxxxxxxx
Web: http://eclipsesource.com/munich
Mobil: +49 176 22 85 11 50
Phone: +49 89 21 555 30 - 13
Fax: +49 89 21 555 30 - 19

EclipseSource Muenchen GmbH
Agnes-Pockels-Bogen 1
80992 Muenchen

General Managers: Dr. Jonas Helming, Dr. Maximilian Koegel
Registered Office: Agnes-Pockels-Bogen 1, 80992 Muenchen, Commercial Register Muenchen, HRB 191789

Back to the top