Re: [ejb-dev] Format Specification PR

[<Hussain.NM@xxxxxxxxxxxxx>]

Thanks Tracy for reviewing and merging.

 

I fixed the merge conflicts on PR# 84 and 85. I reviewed both PRs and pushed some more changes:

·        Replaced empty description list to indent paragraph with sidebar block

·        Changed footnotes inside table to table end notes (notes are placed immediately after the table)

 

I completed formatting of all chapters. Just need to rebase them on top of current master and create Pull Requests.

 

Next, I am going to work on changing Java EE references to Jakarta EE.

 

Thanks

Hussain

 

From: ejb-dev-bounces@xxxxxxxxxxx <ejb-dev-bounces@xxxxxxxxxxx> On Behalf Of Tracy Burroughs
Sent: Friday, March 13, 2020 9:53 AM
To: ejb developer discussions <ejb-dev@xxxxxxxxxxx>
Subject: Re: [ejb-dev] Format Specification PR

 

Approved and merged PR #76.  Will try to complete my review for 84 and 85 tomorrow.


-- Tracy Burroughs (tkb@xxxxxxxxxx)
-- WebSphere Application Server Development
-- IBM Rochester,  Dept WG8A    H315/050-2
-- 2800 37th Street NW, Rochester MN 55901-4441




From:        <Hussain.NM@xxxxxxxxxxxxx>
To:        <ejb-dev@xxxxxxxxxxx>
Date:        03/11/2020 11:46 AM
Subject:        [EXTERNAL] Re: [ejb-dev] Format Specification PR
Sent by:        ejb-dev-bounces@xxxxxxxxxxx

---

I have created two PRs #84and #85for Chapters 1-4.

Thanks
Hussain

---

From: ejb-dev-bounces@xxxxxxxxxxx <ejb-dev-bounces@xxxxxxxxxxx> on behalf of Tracy Burroughs <tkb@xxxxxxxxxx>
Sent: Wednesday, March 11, 2020 08:39 PM
To: ejb developer discussions <ejb-dev@xxxxxxxxxxx>
Subject: Re: [ejb-dev] Format Specification PR
 

My preference is that smaller PRs are easier to review; however I don't think these formatting changes would need to be done with a PR per chapter.  I'm fine with grouping a few chapters together per PR.

Thanks for all your effort on this.


-- Tracy Burroughs (tkb@xxxxxxxxxx)
-- WebSphere Application Server Development
-- IBM Rochester,  Dept WG8A    H315/050-2
-- 2800 37th Street NW, Rochester MN 55901-4441




From:        <Hussain.NM@xxxxxxxxxxxxx>
To:        <ejb-dev@xxxxxxxxxxx>
Date:        03/11/2020 09:02 AM
Subject:        [EXTERNAL] [ejb-dev] Format Specification PR
Sent by:        ejb-dev-bounces@xxxxxxxxxxx

---

 

I am currently working on formatting the specification to match the original specification.

 

Do I raise a single PR with all changes or should I raise a separate PR for each chapter?

 

Current Status:

Pending:

Chapters 8-10

Chapter 12

Completed:

Table of Contents: (merged)

Chapter 11 (merged)

Related Documents (pending review)

Footnotes (pending review)

Chapters 1-7

Chapters 13-19

 

My current development version of specification is available in the below link

https://hussainnm.github.io/ejb-api/

 

Thanks

Hussain

_______________________________________________
ejb-dev mailing list
ejb-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/ejb-dev


_______________________________________________
ejb-dev mailing list
ejb-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/ejb-dev

This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored. This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored.