[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [ejb-dev] 4.0.0-RC1 release contains jakarta.transaction classes?
|
Not sure about your
first item.... but agree all the rest should be fixed/done before RC2.
Just comparing against the interceptors project, and the legal documents
definitely appear incorrect for the jakarta-ejb-api-4.0.0-RC1.jar.
I also noticed the project cannot be built with Java 11 due to javadoc
errors, so would be very nice to get that fixed.Agree it should
target 1.8, not 1.6.
-- Tracy Burroughs (tkb@xxxxxxxxxx)
-- WebSphere Application Server Development
-- IBM Rochester, Dept WG8A H315/050-2
-- 2800 37th Street NW, Rochester MN 55901-4441
From:
<Hussain.NM@xxxxxxxxxxxxx>To:
<ejb-dev@xxxxxxxxxxx>Date:
03/07/2020
08:46 AMSubject:
[EXTERNAL]
Re: [ejb-dev] 4.0.0-RC1 release
contains jakarta.transaction
classes?Sent
by: ejb-dev-bounces@xxxxxxxxxxx
Before we release
RC2, I propose we fix the following issues:- [ejb-parent] Remove
the ee4j-parent in root pom.xml
- The api project adds
it as parent project
- The spec project
does not need it as there is no need to deploy to maven central
- I don't have a view
on how the Jenkins release job is configured, my guess is the ee4j-parent
version is read from the top-level project to perform the release. This
can be fixed in the script by selecting the api project when evaluating
the ee4j-parent version. My assumptions are based on the https://wiki.eclipse.org/JakartaEE_New_Infra_ReStaging_Job
#
Compute release version
RELEASE_VERSION=`mvn -B -pl api ${HELP_PLUGIN}:evaluate -Dexpression=project.version
2> /dev/null | grep -E '^[0-9]+(\.[0-9]+)+$'`
# Compute parent version
PARENT_VERSION=`mvn -B -pl api ${HELP_PLUGIN}:evaluate -Dexpression=project.parent.version
2> /dev/null | grep -E '^[0-9]+(\.[0-9]+)+$'`
- [api] Merge 4.0.0-RC1
branch in master
- [api] Add an empty
relativePath to parent to resolve ee4j-parent from repository instead of
parent directory
- [api] Legal documents
in release jar are incorrect
- The CDDL license.txt
is included in META-INF. This is pulled from org.glassfish:legal:1.1 by
maven-remote-resources-plugin. This needs to be removed
- The legal.doc.source
property is pointing to current directory, this should be changed to parent
directory. The License.md and Notice.md reside in the parent directory
- [api] Remove the
maven-release-plugin, maven-gpg-plugin and nexus-staging-maven-plugin as
they are already configured in the parent
- [api] Upgrade java
compiler source and target version from 1.6 to 1.8
- [api] Unable to build
with JDK11 - Fix javadoc issues and configure maven-javadoc-plugin with
source as 1.8
- [api] Prepare for
4.0.0-RC2
- [spec] asciidoc-to-html
does not stamp project version, date and status in HTML output.
- [spec] Remove the
maven-release-plugin as it is unused.
Thoughts
and concerns?ThanksHussain
From: ejb-dev-bounces@xxxxxxxxxxx
<ejb-dev-bounces@xxxxxxxxxxx> on behalf of Tracy Burroughs <tkb@xxxxxxxxxx>
Sent: Saturday, March 7, 2020 01:57 AM
To: ejb developer discussions <ejb-dev@xxxxxxxxxxx>
Subject: Re: [ejb-dev] 4.0.0-RC1 release contains jakarta.transaction
classes? [External]
I agree, this
appears to be a bug; reviewed and merged.
-- Tracy Burroughs (tkb@xxxxxxxxxx)
-- WebSphere Application Server Development
-- IBM Rochester, Dept WG8A H315/050-2
-- 2800 37th Street NW, Rochester MN 55901-4441
From: <Hussain.NM@xxxxxxxxxxxxx>
To: <ejb-dev@xxxxxxxxxxx>
Date: 03/06/2020
12:32 AM
Subject: [EXTERNAL]
Re: [ejb-dev] 4.0.0-RC1 release contains
jakarta.transaction classes?
Sent by: ejb-dev-bounces@xxxxxxxxxxx
I
have raised another issue #80regarding
removal of javax.transaction from MANIFEST.MF.
In
the current build, the MANIFEST.MF has javax.transaction which is explicitly
added during the build.
Import-Package:
jakarta.ejb;version="4.0.0",jakarta.ejb.embeddable;ver sion="4.0.0",jakarta.ejb.spi;version="4.0.0",jakarta.transaction;vers ion="2.0",javax.naming,javax.transaction;version="[1.3,2.0)" Tool:
Bnd-0.0.255 Implementation-Vendor:
Eclipse Foundation Export-Package:
jakarta.ejb.spi;uses:="jakarta.ejb,jakarta.ejb.embedda ble";version="4.0.0",jakarta.ejb;uses:="jakarta.transaction";version= "4.0.0",jakarta.ejb.embeddable;uses:="jakarta.ejb.spi,jakarta.ejb,jav
ax.naming";version="4.0.0" |
My
proposed fix is to remove it from pom.xml. The MANIFEST.MF will look like
below
Import-Package:
jakarta.ejb;version="4.0.0",jakarta.ejb.embeddable;ver sion="4.0.0",jakarta.ejb.spi;version="4.0.0",jakarta.transaction;vers ion="2.0",javax.naming Tool:
Bnd-0.0.255 Implementation-Vendor:
Eclipse Foundation Export-Package:
jakarta.ejb.spi;uses:="jakarta.ejb,jakarta.ejb.embedda ble";version="4.0.0",jakarta.ejb;uses:="jakarta.transaction";version= "4.0.0",jakarta.ejb.embeddable;uses:="jakarta.ejb.spi,jakarta.ejb,jav ax.naming";version="4.0.0" |
Please
review and confirm if this is a bug or not?
Thanks
Hussain
From:ejb-dev-bounces@xxxxxxxxxxx
<ejb-dev-bounces@xxxxxxxxxxx> On Behalf Of Kevin Sutter
Sent: Friday, March 6, 2020 4:27 AM
To: ejb developer discussions <ejb-dev@xxxxxxxxxxx>
Subject: Re: [ejb-dev] 4.0.0-RC1 release contains jakarta.transaction
classes?
[External]
Thanks,
Hussain! (And, Tracy for review, approval, and merging.)
This type of change would require a refresh of the EJB API to RC2... Anybody
want to take a shot at doing that operation? Thanks!
---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail: sutter@xxxxxxxxxx Twitter: @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)
LinkedIn: https://www.linkedin.com/in/kevinwsutter
From: <Hussain.NM@xxxxxxxxxxxxx>
To: <ejb-dev@xxxxxxxxxxx>
Date: 03/05/2020
00:13
Subject: [EXTERNAL]
Re: [ejb-dev] 4.0.0-RC1 release contains jakarta.transaction
classes?
Sent by: ejb-dev-bounces@xxxxxxxxxxx
I
have created a PR
#79with
the fix.
The
glassfishbuild-maven-plugin is adding the project dependencies into the
source. This was previously used to pull in xml-rpc-api sources. I have
removed the plugin from pom.xml.
Also
I have removed the unnecessary dependency to cdi-api. This was added to
compile the project because of the regression caused by the above plugin.
Please
review, approve and merge.
Thanks
Hussain
From:ejb-dev-bounces@xxxxxxxxxxx
<ejb-dev-bounces@xxxxxxxxxxx>
On Behalf Of Kevin Sutter
Sent: Thursday, March 5, 2020 1:25 AM
To: ejb developer discussions <ejb-dev@xxxxxxxxxxx>
Subject: Re: [ejb-dev] 4.0.0-RC1 release contains jakarta.transaction
classes?
Yes,
please open an Issue against ejb-api, Tracy. Thanks!
---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail: sutter@xxxxxxxxxx Twitter: @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)
LinkedIn: https://www.linkedin.com/in/kevinwsutter
From: Bill
Shannon <bill.shannon@xxxxxxxxxx>
To: ejb
developer discussions <ejb-dev@xxxxxxxxxxx>,
Tracy Burroughs <tkb@xxxxxxxxxx>
Date: 03/04/2020
13:25
Subject: [EXTERNAL]
Re: [ejb-dev] 4.0.0-RC1 release contains jakarta.transaction
classes?
Sent by: ejb-dev-bounces@xxxxxxxxxxx
Yes, that's an error. It should be a dependency, not included.
Tracy Burroughs wrote on 3/4/20 10:47 AM:
I noticed the "jakarta.ejb-api-4.0.0-RC1.jar" API jar contains
classes from the "jakarta.transaction" package. They also
show up in the javadoc jar as well.
https://jakarta.oss.sonatype.org/content/repositories/releases/jakarta/ejb/jakarta.ejb-api/4.0.0-RC1/
I assume this is an error? I don't see the source for this in the
ejb project.
-- Tracy Burroughs (tkb@xxxxxxxxxx)
-- WebSphere Application Server Development
-- IBM Rochester, Dept WG8A H315/050-2
-- 2800 37th Street NW, Rochester MN 55901-4441
_______________________________________________
ejb-dev mailing list
ejb-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/ejb-dev__;!!GqivPVa7Brio!LrFMaFMdPeigURTOaIqPcwckJWOT5IheB-ndlScZHhzEz4O_78QOyoWNTyRLDQFSnw$
_______________________________________________
ejb-dev mailing list
ejb-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/ejb-dev
This e-mail and any files transmitted with it are for the sole use of the
intended recipient(s) and may contain confidential and privileged information.
If you are not the intended recipient(s), please reply to the sender and
destroy all copies of the original message. Any unauthorized review, use,
disclosure, dissemination, forwarding, printing or copying of this email,
and/or any action taken in reliance on the contents of this e-mail is strictly
prohibited and may be unlawful. Where permitted by applicable law, this
e-mail and other e-mail communications sent to and from Cognizant e-mail
addresses may be monitored. This e-mail and any files transmitted with
it are for the sole use of the intended recipient(s) and may contain confidential
and privileged information. If you are not the intended recipient(s), please
reply to the sender and destroy all copies of the original message. Any
unauthorized review, use, disclosure, dissemination, forwarding, printing
or copying of this email, and/or any action taken in reliance on the contents
of this e-mail is strictly prohibited and may be unlawful. Where permitted
by applicable law, this e-mail and other e-mail communications sent to
and from Cognizant e-mail addresses may be monitored. _______________________________________________
ejb-dev mailing list
ejb-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/ejb-dev
This e-mail and any files transmitted with it are for the sole use of the
intended recipient(s) and may contain confidential and privileged information.
If you are not the intended recipient(s), please reply to the sender and
destroy all copies of the original message. Any unauthorized review, use,
disclosure, dissemination, forwarding, printing or copying of this email,
and/or any action taken in reliance on the contents of this e-mail is strictly
prohibited and may be unlawful. Where permitted by applicable law, this
e-mail and other e-mail communications sent to and from Cognizant e-mail
addresses may be monitored. This e-mail and any files transmitted with
it are for the sole use of the intended recipient(s) and may contain confidential
and privileged information. If you are not the intended recipient(s), please
reply to the sender and destroy all copies of the original message. Any
unauthorized review, use, disclosure, dissemination, forwarding, printing
or copying of this email, and/or any action taken in reliance on the contents
of this e-mail is strictly prohibited and may be unlawful. Where permitted
by applicable law, this e-mail and other e-mail communications sent to
and from Cognizant e-mail addresses may be monitored.
_______________________________________________
ejb-dev mailing list
ejb-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/ejb-dev
This e-mail and any files transmitted
with it are for the sole use of the intended recipient(s) and may contain
confidential and privileged information. If you are not the intended recipient(s),
please reply to the sender and destroy all copies of the original message.
Any unauthorized review, use, disclosure, dissemination, forwarding, printing
or copying of this email, and/or any action taken in reliance on the contents
of this e-mail is strictly prohibited and may be unlawful. Where permitted
by applicable law, this e-mail and other e-mail communications sent to
and from Cognizant e-mail addresses may be monitored. This e-mail and any
files transmitted with it are for the sole use of the intended recipient(s)
and may contain confidential and privileged information. If you are not
the intended recipient(s), please reply to the sender and destroy all copies
of the original message. Any unauthorized review, use, disclosure, dissemination,
forwarding, printing or copying of this email, and/or any action taken
in reliance on the contents of this e-mail is strictly prohibited and may
be unlawful. Where permitted by applicable law, this e-mail and other e-mail
communications sent to and from Cognizant e-mail addresses may be monitored.
_______________________________________________
ejb-dev mailing list
ejb-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/ejb-dev