Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ecf-dev] building problem with JMS provider p2 repository
Thanks for the update Cristiano.   Great to hear everything is working for you now.

If you have the time, we would be most grateful if you could comment on the ECF feature restructuring bug [1]...i.e. describing your use case a little (use of ECF for Tycho-built server?)...and give any suggestions and/or insights you might have about how things could be made more easily consumable for your environment, tooling, and use case (e.g. multiple or single p2, maven, karaf repos...features/groups of bundles available together or apart...relative to their current structure, etc.)

Thanks...and please keep us informed if we can help further.

Scott

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=409787

On 12/6/2013 1:17 PM, Cristiano Gavião wrote:
Hi again,

I've created the sample project. There are nothing wrong with the JMS p2 or the 3.7.1 p2 being provided by ECF team !  Sorry for the time lost, guys !

We discovered the problem...  it was a trick from maven/tycho and a long headache for me :(

For this project we separate aggregators pom from parent pom, so not every project/module inherits from the same parent inside one agreggator. That bring us some facilities but it could be dangerous.... :)

And was that what happen: our p2 project (that is consuming our ECF headless feature) was using a different parent pom than our ECF headless feature project.

Instead of I do set the JMS p2 repository in the common parent of both parents, I set it in our ECF headless feature's parent only.

So, when tycho was building our ECF headless feature that consumes ECF JMS feature, everything was ok.  But when it tried to build the p2 project then tycho failed because the repo wasn't there... :-/

I would like to thanks everyone here that tried to help me. your suggestions help me to figure out !

cheers,

Cristiano



2013/12/6 Scott Lewis <slewis@xxxxxxxxxxxxx>
Hi Cristiano,


On 12/6/2013 5:13 AM, Cristiano Gavião wrote:
Hello guys,

Scott, I indeed took a look using the p2-browser... and didn't see anything wrong... :s

I'll prepare a small project today just to build a small feature with tycho like the one that I'm building to reproduce the issue.

Initially, I'll add one bundle inside the feature and will add others in sequence... just to see if the problem could be any dependency of jars. Btw, I don't think it is the problem since my building was ok when I substitute the jms feature by all bundles instead.

So I understand...the build problem only occurs when you include the entire JMS feature?...and does not occur when the individual bundles in the feature (4 bundles I think) are included directly into your feature?



Then I'll put it in github, so you can take a look. you will just need to have at least maven 3.1 installed to run.

Ok, thanks.  Hopefully that will help identify what's going on.

Also...something that occurred to me...the JMS jars are not signed (since they are not deployed via EF)...while of course the ECF releases are signed.   I remember seeing something somewhere about complexities in Tycho WRT signed bundles...is it possible that's affecting you?

Thanks,

Scott




cheers,

Cristiano

On 05/12/13 14:59, Scott Lewis wrote:
On 12/5/2013 8:32 AM, Wim Jongman wrote:
[ERROR]   Missing requirement: org.lunifera.dependencies.feature.ecf.headless.feature.group 3.7.1 requires 'org.eclipse.ecf.provider.jms 0.0.0' but it could not be found

What is this:  org.eclipse.ecf.provider.jms 0.0.0

And why not: org.eclipse.ecf.provider.jms.feature 0.0.0

Could there be some other definition that does not play well?

It's a reasonable question.   There is a bundle:  org.eclipse.ecf.provider.jms ...it's the basic support for JMS that's depended upon by the ActiveMQ provider.

Unfortunately, I'm still struggling with why this is an issue for Christiano's build.  If I use the p2 browser [1] to inspect this repo's metadata, here's what I see:




This does correspond with what's present in feature.xml for the org.eclipse.ecf.provider.jms.feature:

https://github.com/ECF/JMS/blob/master/features/org.eclipse.ecf.provider.jms.feature/feature.xml

So nothing obviously wrong there.   

Incidently...here's the manifest.mf for org.eclipse.ecf.provider.jms:

https://github.com/ECF/JMS/blob/master/bundles/org.eclipse.ecf.provider.jms/META-INF/MANIFEST.MF

One thing that occurs to me looking at this manifest is that it has this:

Import-Package: javax.jms;version="1.1.0",


Which obviously means that it has to have the javax.jms version 1.1 available (it is available in the ECF JMS repo as you can see above...we get it/include it from Orbit).

Christiano...is is possible that there is a conflict in your build with some other version of javax.jms?   I don't really see this as likely, but it's probably worth checking.

One other thing that just occurred to me....there was a problem with Java 7's handling of embedded jars that was causing fits for the simultaneous release build (and ECF) [2].   Perhaps this is still a problem in Tycho.   One way to test whether this would be the problem would be to simply delete the *.pack.gz files in your local copy of this p2 repo (from the features and plugins subdirectories):

http://download.ecf-project.org/repo/C-HEAD-jms.feature/lastSuccessful/archive/site.p2

Deleting the *.pack.gz files will still leave the *.jar (unpacked) bundles...and then these can/will be installed when Tycho/p2 is run.  Christiano...could you give this a try?

Assuming this is not the problem either, I think the next steps are that one of us (I will volunteer if someone else is not already doing it) should make a simple feature which includes just the ECF JMS feature contents and it's dependencies and see if we can try to reproduce the problem in isolation...and/or with PDE builder (since I don't have Tycho installed).   It isn't obvious from the p2 browser output above that it's a problem with the ECF JMS repo...as that looks OK to me...but a simple feature that includes just the ECF JMS feature could show some metadata problem that isn't apparent from the browser.

Thanks,

Scott





[1] https://github.com/ifedorenko/p2-browser
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=361628





On Thu, Dec 5, 2013 at 3:46 PM, Markus Alexander Kuppe <ecf-dev_eclipse.org@xxxxxxxxxxx> wrote:
On 12/05/2013 03:40 PM, "Cristiano Gavião" <cvgaviao@xxxxxxxxx>" wrote:
>
> I just did a: wget -r --no-parent
> http://download.ecf-project.org/repo/C-HEAD-jms.feature/lastSuccessful/archive/site.p2/
>
> interesting is that the structure seems to be ok...  I could check the
> local p2 with the eclipse install dialog... and it was ok...
>
> can't say why only this jms feature is problematic... :)

Can you try to strip down the feature to the bare minimum? Maybe it's a
just a glitch in the XML somewhere.

M.
_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev



_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev




_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev




_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev


_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev




--
"Tudo vale a pena se a alma não é pequena..." 


_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev

Back to the top