Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ecf-dev] [Gsoc] - Remote serice Testing TooL
Hi Markus

Here[1] i have committed changes , I have done most of the changes

In current design i have used  "IMemberValuePair[] memberValuePairs = iAnnotation.getMemberValuePairs(); " to get annotation parameters but this method return snapshot kind params what i mean is

@RemoteService(type=Annotationtype.ASYNC) this method return  key-type and value=Annotationtype.ASYNC , not the real value of the enum. So i need to do couple of changes to introduce a Enum for users ,

Also that command handler extension point i have never used before that change also required some time. I have started to do this change already.

Every thing else is OK

Also I would like to thanks for code review comments I have learn lot


On Thu, Aug 1, 2013 at 3:20 AM, <ecf-dev_eclipse.org@xxxxxxxxxxx> wrote:
Salinda Jayawardana <salinda.uwu@xxxxxxxxx> wrote:
>Hi Markus
>
>My repository name =Salindauwu
>
>According your request  I have update my road map and brought up the
>test
>cases development as the next task
>
>Also is it Ok to have separate project for the Test or should I add
>test
>cases into same project ??
>
>Thanks
>Salinda
>
>
>On Wed, Jul 31, 2013 at 10:10 PM, Salinda Jayawardana
><salinda.uwu@xxxxxxxxx
>> wrote:
>
>> HI Markus
>>
>> I have fork the code into my repository[1] there  I will be doing my
>> changes
>>
>> [1]-https://github.com/Salindauwu/gsoc2013salinda
>>
>> Thanks
>> /Jasintha
>>
>>
>> On Wed, Jul 31, 2013 at 9:55 PM, Harshana Eranga Martin <
>> harshana05@xxxxxxxxx> wrote:
>>
>>> Hi Suneth,
>>>
>>> I need a Task Break Down for this as what you have done, tasks
>>> completed, amount of project goals achieved, etc.
>>>
>>> Also some sort of documentation explaining these is also would be
>good
>>> for me to do the evaluation!
>>>
>>>
>>> Thanks and Regards,
>>> Harshana Martin
>>> --
>>> Harshana Eranga Martin
>>> Senior Software Engineer,
>>> WSO2 Inc.
>>> Web: http://wso2.com
>>>
>>> ECF Committer: http://www.eclipse.org/ecf/
>>> Blog: http://harshana05.blogspot.com
>>> Profile: https://www.google.com/profiles/harshana05
>>>
>>>
>>> On 30 July 2013 12:28, Suneth Vijayindu <svijayindu@xxxxxxxxx>
>wrote:
>>> > Hi Harshana Ayye,
>>> >
>>> > Here is the link for the repo and for my blog.
>>> > https://github.com/vijayindu/ecf/tree/pdetemplate
>>> > http://vijayindu.blogspot.com/
>>> >
>>> >
>>> > On Tue, Jul 30, 2013 at 2:10 AM, Harshana Eranga Martin
>>> > <harshana05@xxxxxxxxx> wrote:
>>> >>
>>> >> Hi Suneth,
>>> >>
>>> >> Please note the below note from Markus!
>>> >>
>>> >> Thanks and Regards,
>>> >> Harshana Martin
>>> >> --
>>> >> Harshana Eranga Martin
>>> >> Senior Software Engineer,
>>> >> WSO2 Inc.
>>> >> Web: http://wso2.com
>>> >>
>>> >> ECF Committer: http://www.eclipse.org/ecf/
>>> >> Blog: http://harshana05.blogspot.com
>>> >> Profile: https://www.google.com/profiles/harshana05
>>> >>
>>> >>
>>> >> On 29 July 2013 01:01, Markus Alexander Kuppe
>>> >> <ecf-dev_eclipse.org@xxxxxxxxxxx> wrote:
>>> >> > On 07/23/2013 07:39 PM, Markus Alexander Kuppe wrote:
>>> >> >> On 07/23/2013 03:34 PM, Salinda Jayawardana wrote:
>>> >> >>> Thank you for putting me into the right track I am almost
>finish
>>> the
>>> >> >>> above task (Generating codes) will update the wiki and jura
>with
>>> the
>>> >> >>> detail explanation about the solution Code will be uploaded
>into
>>> >> >>> github
>>> >> >>
>>> >> >>
>>> >> >> Hi Salinda,
>>> >> >>
>>> >> >> just for the record and to make sure we are all on the same
>page
>>> >> >> here...
>>> >> >>
>>> >> >> The fact that you disappeared for weeks without notice or any
>>> visible
>>> >> >> progress means your midterm results will have to be excellent
>and
>>> >> >> exceed
>>> >> >> my expectations in order for you to pass midterm. If we/I do
>not see
>>> >> >> functional code (covering a good portion of the project's use
>cases)
>>> >> >> with proper documentation and unit tests by the end of this
>week,
>>> will
>>> >> >> mean you fail midterm.
>>> >> >>
>>> >> >> Generally, GSoC is about _open source development_ and one
>essential
>>> >> >> characteristic of OSS is open and visible collaboration. For
>you
>>> this
>>> >> >> means we expect regular progress reports, asking/answering
>questions
>>> >> >> publicly on the mailing list, bugs opened and commented on in
>>> Bugzilla
>>> >> >> (btw. for you this is actually an advantage as you get to show
>your
>>> >> >> skills publicly and can later add them to your resume).
>>> >> >>
>>> >> >> To summarize:
>>> >> >> - Exceptional results (code-wise) expected to pass midterm
>(and
>>> receive
>>> >> >> midterm payment)
>>> >> >> - Blog post about current progress and future road-map
>>> >> >>
>>> >> >> - Assuming you pass midterm, public participation and
>collaboration
>>> >> >> within ECF will be a hard requirement to pass final exam
>>> (exceptional
>>> >> >> results alone won't be enough to pass finals)
>>> >> >>
>>> >> >> Regards
>>> >> >> Markus
>>> >> >
>>> >> >
>>> >> > Hi Salinda,
>>> >> >
>>> >> > any updates? Right now I do not see (visible) progress that
>would
>>> >> > justify a positive midterm evaluation.
>>> >> >
>>> >> > Btw. keep in mind that I will need a day or two to study your
>>> results.
>>> >> > Thus, I need your work by Wednesday 07/31 8am UTC.
>>> >> >
>>> >> > Markus
>>> >> > _______________________________________________
>>> >> > ecf-dev mailing list
>>> >> > ecf-dev@xxxxxxxxxxx
>>> >> > https://dev.eclipse.org/mailman/listinfo/ecf-dev
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > Thank You
>>> > Vijayindu
>>> _______________________________________________
>>> ecf-dev mailing list
>>> ecf-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/ecf-dev
>>>
>>
>>
>
>
>------------------------------------------------------------------------
>
>_______________________________________________
>ecf-dev mailing list
>ecf-dev@xxxxxxxxxxx
>https://dev.eclipse.org/mailman/listinfo/ecf-dev

Hi salinda,

Using a a fork on github is fine for the moment.

Moving unit test later isn't a big deal. Fine if they share a project/bundle with the implementation.

Anyway, I'm surprised that you focus on testing. Have really addressed all my comments and recommendations in the code review branch?

M.
_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev

Back to the top