Re: [ecf-dev] Fwd: Using framework util

[tishan pubudu kanishka dahanayakage <dtishanpubudu@xxxxxxxxx>]

Hi,

On Wed, Aug 8, 2012 at 12:18 PM, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:

Hi,

Sorry for my brevity but I am mobile only for a couple of weeks.

It is totally ok. Appreciate your help and guidance so far.

In general you should not hold on to an OSGi service the way you do. Services can come an go.

Instead, always get a fresh copy of the service every time the user calls the getcontainermanager method.

You could also consider getting the service straight from FrameworkUtil instead if using a tracker.

Acknowledged. I will do the necessary changes.

Met vriendelijke groet,

Wim

On 7 aug. 2012, at 21:43, tishan pubudu kanishka dahanayakage <dtishanpubudu@xxxxxxxxx> wrote:

HI Wim,
Changes were done and push into git repo[1]. Can you have a quick look and verify whether the approach is correct.
[1] https://github.com/tishan89/Newsreader/blob/master/bundles/org.eclipse.ecf.channel.core/src/org/eclipse/ecf/channel/core/SalvoUtil.java
Thanks in advance,
Tishan

On Tue, Aug 7, 2012 at 1:38 AM, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:

>>
>> The context is null so the constructor will fail. Use FrameworkUtil
>

> to get the context. (hit enter too soon)
>

Cheers,

Wim

_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev

--
Regards,
Tishan

_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev

_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev

-- 
Regards,
Tishan