At the time, I tried to get a patch into gerrit. I kept screwing up the commits and they had to be undone by one of the team members. I remember spending more time fighting the system than I did coding. It was quite embarrassing [1].
All this was probably due to an early version of gerrit and an early version of git.
When I look back to the history [1] it does contain a nice amount of information.
Would you briefly describe your experiences with using gerrit for
the git project?
My hope was that *particularly* for non-committer contributions,
that gerrit could make things easier/quicker/more efficient than
reviewing attachments to bugs. If it doesn't actually accomplish
that, however...or costs a lot to do that...then I don't want to
add process.
Thanks,
Scott
On 7/31/2012 1:19 AM, Wim Jongman wrote:
Sure.
I am a bit concerned about how effective it will be given our
scarce resources. It was quite complicated to me when I tried to
contribute to the git project. Hence my reservations.
Anyway, I am happy to give it another try. I
will try to free some time to investigate.
I have looked at the wiki and the previous discussion
as pointed out by Scott and have this question: What
problem is solved with Gerrit?
Assumption: Code reviews are desired/desirable...at least
under some circumstances (e.g. contributions from
non-committers)
If you grant the above assumption, I would say that Gerrit
provides support for automating doing such code reviews (like
any tool IMHO, it doesn't 'solve' the problem but rather
'improves/simplifies/supports' such a process).
It's not my intention/expectation that all commits/pushes to
ECF would require a Gerrit review. But there are occasions
when having code reviews...and having support for doing
so...would be useful IMHO (at least there are occasions when I
would like to request that others review my contributions).
On 7/29/2012 11:03 PM, Markus Alexander Kuppe
wrote:
<stuff deleted>
+1 for Gerrit.
We would probably have to host our own
instance or have the EF
webmasters integrate our Jenkins server with
Gerrit for us (assuming we
want/need a review system <> build
integration).
Hmmm. I had been assuming that we would just
follow the process for requesting Gerrit usage
via the EF
...but I see what you mean about integrating
with our Jenkins server.
Markus do you have any thoughts on how would you
like to handle interacting with the EF admins
about what's the best/right course here (e.g.
hosting our own Gerrit vs. using EF Gerrit
installation)? I would like to see review
system and build system integration (as Alex's
video demonstrates)...but I'm not sure what this
will take...and I certainly don't want to take
on a whole lot of additional integration (and
the inevitable maintenance)...if we don't have
to.
