On Tue, Jul 31, 2012 at 2:48 PM, Wim Jongman
<wim.jongman@xxxxxxxxx> wrote:
About HookedNewsGroupProvider: The extension point is now geared towards NNTP obviously. I think we should move this stuff to the NNTP specific part? what doe you think?
What you are suggesting is
to have a HookedNewsGroupProvider in the NNTP context and replace it's
place with another generic class. right?
I have been thinking about
this for a some days now. The Salvo ui is designed very tightly coupled
with NNTP. But at UI level we should not be even touching on protocol
specific stuff. Front end should be a clear separation from backend IMO.
Front end should only have some pages, wizards etc and it will display
what is intended and fetch the user responses to the back end.
Now to achieve this is
current Salvo we have to go for a complete re-design. We have to re
design the UI classes and then use some kind of a intermediate layer say
'UIManager' to handle data flow between UI and backend. This approach
will introduce a clear separation between UI and backend.
But this approach will
require some time which is obviously what we do not have now. I can make
Salvo work with tweaks but it will introduce an architectural failure
one day when we try to move on.
But obviously from what
I'm experiencing now starting things from fresh will be more easier other
than tweaking the existing ui. ;)
Regards,
Wim
On Tue, Jul 31, 2012 at 11:15 AM, Wim Jongman
<wim.jongman@xxxxxxxxx> wrote:
Hi,
About the extension point:
This is a really cool extension point [1]. Projects can use this extension point to point at their newsgroups. When the user selects "ask a question" and the current perspective is for example the ECF perspective then the newsgroup will be suggested as a place to drop the question
Regards,
Wim
On Tue, Jul 31, 2012 at 10:52 AM, tishan pubudu kanishka dahanayakage
<dtishanpubudu@xxxxxxxxx> wrote:
Hi wim,
In the current implementation SelectNewsGroupWizardPage uses a HookedNewsGroupProvider go get a list of NewsGroup(MessageSource) providers. Inside HookedNewsGroupProvide it uses a extension point defined by org.eclipse.ecf.salvo.ui.newsgroupProvider.
IConfigurationElement[] config = Platform.getExtensionRegistry()
.getConfigurationElementsFor(EXTENSIONPOINT_ID);
for (final IConfigurationElement newsgroup : config) {
IConfigurationElement enablement = newsgroup
.getChildren("enablement")[0];
I also checked the NewsGroupProvider.java. Still could not get clear idea of what is happening. Can you please clarify on this more.
Also inside HookedNewsGroupProvider ServerStoreFacade instance is used every where. As far as I understand we have to use protocol specific serverStoreFacade inside HookedNewsGroupProvider. But In my solution each protocol specific ServerStoreFacade resides inside protocol specific container. So should we pass that instance to HookedNewsGroupProvider or create new serverStoreFacade differentiating by protocol using the lame logic to create different containers and use them.
--
Regards,
Tishan
_______________________________________________
ecf-dev mailing list
ecf-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ecf-dev
