Re: AW: [dtp-dev] column definitions with suffix

[Hemant S Kolwalkar <hskolwal@xxxxxxxxxx>]

Hi Adrian,

yes, please
propose this as a bugfix.

thanks,

- Hemant

"Goerler, Adrian" <adrian.goerler@xxxxxxx>
Sent by: dtp-dev-bounces@xxxxxxxxxxx

07/18/2007 12:38 AM

Please respond to
DTP development mailing list <dtp-dev@xxxxxxxxxxx>

To	"DTP development mailing list" <dtp-dev@xxxxxxxxxxx>
cc
Subject	AW: [dtp-dev] column definitions with suffix

Hi Hemant,
 
I was a bit quick with my last
answer. The property "displayName" is evaluated in the getPredefinedDataTypeFormattedName
method for binary types only. On MaxDB, however, we would need the same
functionality for character types (CHARACTER, CHARACTER_VARYING and CHARACTER_LARGE_OBJECT)
also. Should we propose this as a bugfix?
 
Best regards,
 
Adrian

---

Von: dtp-dev-bounces@xxxxxxxxxxx
[mailto:dtp-dev-bounces@xxxxxxxxxxx] Im Auftrag von Hemant S Kolwalkar
Gesendet: Dienstag, 17. Juli 2007 19:22
An: DTP development mailing list
Cc: dtp-dev@xxxxxxxxxxx; dtp-dev-bounces@xxxxxxxxxxx
Betreff: Re: [dtp-dev] column definitions with suffix


Hi Adrian, 

the DDL Generator should be using the following method from DatabaseDefinition.
For CHAR () FOR BIT DATA,
the length gets plugged in in this method. 

public String getPredefinedDataTypeFormattedName(PredefinedDataType
predefinedDataType); 

and meta-data in the DB2 UDB dbdefinition for CHAR () FOR BIT DATA should
have the displayName entries as below. though i see them missing in the
DB2 UDB database definitions and that could explain the behavior you are
seeing with DB2 UDB. please open a defect for this.

<predefinedDataTypeDefinitions
xmi:id="BINARY_1"
lengthSupported="true"
 defaultLength="1"
displayNameSupported="true"
displayName="CHAR
({0}) FOR BIT DATA" keyConstraintSupported="true"
maximumLength="254"
primitiveType="BINARY"
jdbcEnumType="-2"
javaClassName="byte[]">
    <defaultValueTypes>NULL</defaultValueTypes>
    <name>CHAR
FOR BIT DATA</name>
    <name>CHARACTER
FOR BIT DATA</name>
    <name>CHAR
() FOR BIT DATA</name>
    <name>CHARACTER
() FOR BIT DATA</name>
  </predefinedDataTypeDefinitions>

thanks, 

- Hemant

"Goerler, Adrian" <adrian.goerler@xxxxxxx>
Sent by: dtp-dev-bounces@xxxxxxxxxxx

07/17/2007 02:22 AM

Please respond to
DTP development mailing list <dtp-dev@xxxxxxxxxxx>

To	<dtp-dev@xxxxxxxxxxx>
cc
Subject	[dtp-dev] column definitions with suffix

Hi DTP-team,

we are currently facing the following issue:

Some database, namely "DB2 UDB iSeries",  "DB2 UDB" and  "DB2 UDB zSeries", have database definitions that contain column definitions with a suffix (e.g. CHAR () FOR BIT DATA).

examples:

DB2 UDB:

<predefinedDataTypeDefinitions xmi:id="BINARY_1" lengthSupported="true"  defaultLength="1" displayNameSupported="true" displayName="CHAR ({0}) FOR BIT DATA" keyConstraintSupported="true" maximumLength="254" primitiveType="BINARY" jdbcEnumType="-2" javaClassName="byte[]">

    <defaultValueTypes>NULL</defaultValueTypes>
  <name>CHAR FOR BIT DATA</name>
  <name>CHARACTER FOR BIT DATA</name>
  <name>CHAR () FOR BIT DATA</name>         <-------
  <name>CHARACTER () FOR BIT DATA</name>    <-------
</predefinedDataTypeDefinitions>
 

DB2 UDB zSeries:

  <predefinedDataTypeDefinitions xmi:id="BINARY_VARYING_1" lengthSupported="true" defaultLength="1" keyConstraintSupported="true" primitiveType="BINARY_VARYING" jdbcEnumType="-3" javaClassName="byte[]">

    <defaultValueTypes>NULL</defaultValueTypes>
  <name>VARCHAR () FOR BIT DATA</name>              <-------
  <name>CHARACTER VARYING () FOR BIT DATA</name>    <-------
  <name>CHAR VARYING () FOR BIT DATA</name>         <-------
</predefinedDataTypeDefinitions>

These databases don't provide a platform-specific DDL generator. If you trigger DDL generation (on the context menu of the datasource explorer) the GenericDDLGenerator is used. It renders

"VARCHAR () FOR BIT DATA (<length>)" instead of  "VARCHAR (<length>) FOR BIT DATA",

for binary types, which is not understood by the database.

We are currently developing a database definition for (MySQL/SAP) MaxDB. Here we are also having data types that require a postfix (e.g. VARCHAR (<length>) UNICODE). We could fix the issue for MaxDB by providing a MaxDB-specific DDLGenarator, but we think it could be addressed within DTP.

We are now a bit puzzled how to get this right and have the following questions:

- Should this issue be addressed by database-specific DDL generators (to be provided) for the individual databases or could it be addressed in the GenericDDLGenerator?

- What is the meaning of the properties "displayNameSupported" and "displayName"? Should these properties be evaluated by the GenericDDLGenerator to infix the length parameter?

Could anyone help us with a clarification?

Thanks and best regards,

Adrian

Adrian Görler
SAP AG
Dietmar-Hopp-Allee 16
D-69190 Walldorf, Germany
T   +49 6227 747474
http://www.sap.com

Sitz der Gesellschaft/Registered Office: Walldorf, Germany
Vorstand/SAP Executive Board: Henning Kagermann (Sprecher/CEO), Léo Apotheker (stellvertretender Sprecher/Deputy CEO), Werner Brandt, Claus Heinrich, Gerhard Oswald, Peter Zencke

Vorsitzender des Aufsichtsrats/Chairperson of the SAP Supervisory Board: Hasso Plattner
Registergericht/Commercial Register Mannheim No HRB 350269

_______________________________________________
dtp-dev mailing list
dtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dtp-dev_______________________________________________
dtp-dev mailing list
dtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dtp-dev