-----Original Message-----
From:
dltk-dev-bounces@xxxxxxxxxxx [mailto:
dltk-dev-bounces@xxxxxxxxxxx]
On Behalf Of Alexey Panchenko
Sent: Friday, July 04, 2008 4:35 AM
To: DLTK Developer Discussions
Subject: Re: [Dltk-dev] Open method action for functional languages
Hi Roy,
First there are some general tips:
A lot of changes in your code patch are just formatting changes. Please
use Eclipse built-in formatter. All team members should use the same
formatting style to avoid unnecessary commits to the repository.
Another tip is to update your working copy before creating the patch. So
the patch will be made against current HEAD - that increases the chances
the patch could be applied. I remember I have changed
PreferenceConstants yesterday and your patch is made against older
version of that file.
And now back to the Open Method action:
The patch length is almost 6k of lines. That is a lot. There are some
new classes. Are all of them required? Is is possible to reuse the code
used for the Open Type dialog? e.g. the OpenMethodHistory - is it
possible to inherit from OpenTypeHistory and override some methods? Or
introduce some AbstractOpenHistory and inherit both from it? The same
questions should asked about other classes.
What do you think?
Thanks,
Alex
----- Original Message -----
From: "Roy Ganor" <
roy@xxxxxxxx>
To:
dltk-dev@xxxxxxxxxxx
Sent: Thursday, July 3, 2008 11:23:43 PM GMT +06:00 Almaty, Novosibirsk
Subject: [Dltk-dev] Open method action for functional languages
Hi all,
One important feature for functional languages developers like TCL and
PHP is the Open Method action (equivalent to Open Type feature or as we
all know it - Ctrl+Shift+T).
I have submitted a patch in Bugzilla
https://bugs.eclipse.org/239470 for
this issue. It is basically a different action and dialog than open type
and doesn't affect anyone who does not bind a command to this action.
_______________________
Roy Ganor
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev
_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev