Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [Dltk-dev] SourceModuleAnnotationModel - catchupWithMarkers 
Sorry, this is about updateBreakpoint().
Probably DbgpBreakpointConfig should be modified and/or additional parameters should be added to make finer control what fields should be included in the command. 

Alex

Johan Compagner wrote:
Why do ScriptMethodEntryBreakpoint and ScriptMethodExitBreakpoint extend from Line? 
But they both dont have or use the linenr...
This is because why it goes wrong in updateBreakpoint()

because there is a linenr set in the DbgpBreakpointConfig;

if (breakpoint instanceof IScriptLineBreakpoint) {
IScriptLineBreakpoint lineBreakpoint = (IScriptLineBreakpoint) breakpoint; 
            config.setLineNo(lineBreakpoint.getLineNumber());
        }
I guess those 2 entry/exit should have the methods of IScriptLineBreakpoint but not of ILineBreakpoint (why is that again in a different interface?) should i refactor this a bit so that they are not in that hierachy? anybody sees big problems with that? 

johan
On Thu, Jul 3, 2008 at 4:01 PM, Johan Compagner <jcompagner@xxxxxxxxx <mailto:jcompagner@xxxxxxxxx>> wrote: 

    hmm yes on the client side it suddenly also becomes a
    linebreakpoint (line nr is -1 there) when it was an entry

    The problem is how do i know not to send the line nr in
    public void updateBreakpoint(String id, DbgpBreakpointConfig
    config) of DbgpBreakpointCommands
    because  DbgpBreakpointConfig doesnt really tell me what kind of
    breakpoint it is..

    that info only sits in a IScriptBreakpoint imlementation (extend)

    johan



    On Thu, Jul 3, 2008 at 3:54 PM, Johan Compagner
    <jcompagner@xxxxxxxxx <mailto:jcompagner@xxxxxxxxx>> wrote:

        i just committed a fix so that UPDATE_BREAKPOINT command will
        always also send the current linenr.
        I guess this will not break any implementation, javascript
        already tried to read the linenr. (which it never got)

        Because the marker does move around now when you change code.
        So the breakpoint linenr should also move.
        I do see that i have to test a bit more, entry/exit
        breakpoints shouldnt then suddenly become line breakpoints
        will test that.


        johan


        On Tue, Jul 1, 2008 at 11:27 AM, Alex Panchenko
        <alex@xxxxxxxxx <mailto:alex@xxxxxxxxx>> wrote:

            Hi Johan,

            I have commented out the call to the catchupWithMarkers()
            because it prevents automatically moving markers when
            lines are inserted/deleted.
            e.g. if I have breakpoint at line 10 and insert lines
            above it - the breakpoint should move down and stay at the
            same line of code, but this functionality was broken.

            Could you please review that code?

            Thanks,
            Alex

            _______________________________________________
            dltk-dev mailing list
            dltk-dev@xxxxxxxxxxx <mailto:dltk-dev@xxxxxxxxxxx>
            https://dev.eclipse.org/mailman/listinfo/dltk-dev




------------------------------------------------------------------------

_______________________________________________
dltk-dev mailing list
dltk-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/dltk-dev

Back to the top