Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cdt-dev] [ptp-dev] Removal of lrparser from CDT

Is it time to revive this topic again? What would the next steps be? A proof-of-concept patch in PTP repo that adds the lrparser? A release review?


Marc-André


From: cdt-dev-bounces@xxxxxxxxxxx <cdt-dev-bounces@xxxxxxxxxxx> on behalf of Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>
Sent: Monday, March 14, 2016 11:58:53 PM
To: CDT General developers list.
Cc: Parallel Tools Platform general developers
Subject: Re: [cdt-dev] [ptp-dev] Removal of lrparser from CDT
 
I've added @noreference tag to all deprecated APIs in cdt.core and cdt.ui. Somebody should probably do the same in other plug-ins.

-sergey

On Sat, Mar 12, 2016 at 3:52 PM, Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx> wrote:
Good idea. I'll try to do it this week.

-sergey

On Sat, Mar 12, 2016 at 11:57 AM, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:
On Fri, Mar 11, 2016 at 5:32 PM, Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx> wrote:
It uses a bunch of APIs deprecated for a long time that are pretty hard to remove unless lrparser stops using them.

Can we make those API's internal now and then remove them in Oxygen?
 

-sergey

On Fri, Mar 11, 2016 at 2:20 PM, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:


On Fri, Mar 11, 2016 at 4:54 PM, Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx> wrote:
Is it possible to announce removal of lrparser and friends in Oxygen unless somebody takes over them? Can this be done now?

Sure, and lets make this statement now. Ideally lrparser is moved up to PTP and then cleaned up to use APIs the CDT community is willing to support.

Are there any public APIs that it's using now that we want to get rid of?

Doug.
 

-sergey

On Fri, Mar 11, 2016 at 12:51 PM, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:

Probably not. It was very late in the cycle to suggest removing this stuff. The only hope was that there would be agreement or silence.

On Mar 11, 2016 3:44 PM, "Alena Laskavaia" <elaskavaia.cdt@xxxxxxxxx> wrote:
So we are not removing any of these stuff? Or this was only about UPC?

On Fri, Mar 11, 2016 at 3:41 PM, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:


On Mar 11, 2016 2:56 PM, "Alena Laskavaia" <elaskavaia.cdt@xxxxxxxxx> wrote:
>
> So can we move UPC to PTP like right now? We will provide support if we break these internal API's (but I don't think we need to invest too much time now in creating public API's )
> We have only few days left before breaking API freeze...
>

No. Moving requires a release review. We don't have time for that now. We can move later and add any needed API as we go.

> On Wed, Mar 9, 2016 at 6:30 PM, Greg Watson <g.watson@xxxxxxxxxxxx> wrote:
>>
>> I guess it was aimed at the general CDT community. The proposal is to remove a piece of functionality that a downstream project is using. I think that would be ok, provided that functionality can be achieved in some other way.
>>
>> Greg
>>
>>> On Mar 9, 2016, at 10:45 AM, Andrew Gvozdev <angvoz.dev@xxxxxxxxx> wrote:
>>>
>>> If you asking me - I can only commit to support XLC error parser.
>>>
>>> Thanks,
>>> Andrew
>>>
>>> On Wed, Mar 9, 2016 at 10:03 AM, Greg Watson <g.watson@xxxxxxxxxxxx> wrote:
>>>>
>>>> PTP definitely wants to continue UPC support. I’m not familiar with the UPC parser, but it looks like it has dependencies on internal interfaces. I’d be willing to move the UPC to PTP, but that would mean CDT would need to provide sufficient API to support language extensions like this. Is that something you would be willing to do?
>>>>
>>>> Greg
>>>>
>>>>> On Mar 9, 2016, at 9:38 AM, Andrew Gvozdev <angvoz.dev@xxxxxxxxx> wrote:
>>>>>
>>>>> I guess they might miss on some of the discussion though. 
>>>>>
>>>>> On Wed, Mar 9, 2016 at 9:34 AM, <ptp-dev-owner@xxxxxxxxxxx> wrote:
>>>>>>
>>>>>> You must subscribe to this list before posting.  Please go to
>>>>>> https://dev.eclipse.org/mailman/listinfo to subscribe to the list,
>>>>>> then try again.  Perhaps you are already subscribed using another
>>>>>> email address; if that is the case, please send email to this list
>>>>>> using the email address you've used to subscribe.
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Andrew 
>>>>>
>>>>> On Mon, Mar 7, 2016 at 3:01 PM, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:
>>>>>>
>>>>>> Yes, they're on the distribution list of the e-mail ;)
>>>>>>
>>>>>> On Mon, Mar 7, 2016 at 2:57 PM, Mike Kucera <mikekucera@xxxxxxxxx> wrote:
>>>>>>>
>>>>>>> The PTP project may still be using it for the UPC parser. You may want to check with them to see if they still need it.
>>>>>>>
>>>>>>> On Mon, Mar 7, 2016 at 2:50 PM, Doug Schaefer <cdtdoug@xxxxxxxxx> wrote:
>>>>>>>>
>>>>>>>> Hey gang,
>>>>>>>>
>>>>>>>> As part of our discussion on clean-up of CDT for CDT 9.0 we asked the question whether we could remove the lrparser and everything that depends on it. As far as we can tell, this work is un-maintained and is preventing us from making some important API changes.
>>>>>>>>
>>>>>>>> We are proposing to remove it but will await word from the community to put a hold on that move.
>>>>>>>>
>>>>>>>> Let us know in the next two weeks.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Doug.
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> cdt-dev mailing list
>>>>>>>> cdt-dev@xxxxxxxxxxx
>>>>>>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>>>>>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> cdt-dev mailing list
>>>>>>> cdt-dev@xxxxxxxxxxx
>>>>>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>>>>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> cdt-dev mailing list
>>>>>> cdt-dev@xxxxxxxxxxx
>>>>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>>>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> cdt-dev mailing list
>>>>> cdt-dev@xxxxxxxxxxx
>>>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> cdt-dev mailing list
>>>> cdt-dev@xxxxxxxxxxx
>>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>>
>>>
>>> _______________________________________________
>>> cdt-dev mailing list
>>> cdt-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>>
>>
>>
>> _______________________________________________
>> cdt-dev mailing list
>> cdt-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/cdt-dev
>
>
>
> _______________________________________________
> ptp-dev mailing list
> ptp-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/ptp-dev



_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev


_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev


_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev


_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev


_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/cdt-dev



Back to the top