| Re: [cdt-dev] Contributing local terminal support for Windows |
|
Hi Sergey / Doug, Splitting out spawner & PTY , and potentially pushing down into Platform, is tracked by this long-standing request: https://bugs.eclipse.org/bugs/show_bug.cgi?id=303083 I’d like to handle the contribution of winpty separate from this splitting / refactoring request (which any CDT committer could initiate any time). I have filed new
https://bugs.eclipse.org/bugs/show_bug.cgi?id=419391 for the winpty contribution. I think we’ll need help from a CDT committer filing the required CQ (I’m not a CDT committer so can’t do that myself). Who could take that on our behalf ? Shall we upload a ZIP archive of the winpty code to be contributed ? Thanks, Martin -- Martin Oberhuber, SMTS / Product Architect – Development Tools,
Wind River direct +43.662.457915.85 fax +43.662.457915.6 From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx]
On Behalf Of Doug Schaefer Love to see this available to the community. And, yeah, all the pty and spawner code should be in the platform, but I wouldn't want that to prevent this functionality from getting
out there. We can start by putting it with the other pty functionality in the CDT and then push it down when the platform team is ready for it. Sent from my BlackBerry Z30 smartphone.
Contributing to CDT is great, but pty support would make even more sense as part of the Platform. Have you considered such an option?
-sergey
On Mon, Oct 14, 2013 at 3:26 AM, Oberhuber, Martin <Martin.Oberhuber@xxxxxxxxxxxxx> wrote:
Dear CDT Committers,
There is a long-standing request to support a fully working local terminal inside an Eclipse view (that is, including tab completion, cursor-up history, and Ctrl+C signal handling).
For Linux, this is already working through the
TM Local Terminal [1], or its clone the
Google ELT plugin [2];
For Windows, this has always been blocked by the lack of a Windows PTY emulation (bug 360517 [3]).
At WindRiver, we have now gotten this to work by using the Open Source
WinPTY library [4], which is under MIT license.
This means, we can now open a fully working CMD prompt inside an Eclipse view (history, tab completion and signal handling).
Bash-like shells like MSYSGIT also fully work in this Eclipse view.
We would like to contribute this to the Eclipse CDT as part of CDT’s PTY handling in
org.eclipse.cdt.core/utils [5].
Part of the code would be contributed from us (Wind River) under EPL, but part of the code must be the MIT-Licensed winpty code.
We need to provide a pre-built executable based on winpty, as well as a pre-built DLL, and link against that dll using Java native code.
We suggest redistributing the MIT licensed source code with the CDT, along with the exe and DLL built from it through CDT fragments.
Does the CDT community agree with this approach in principle ?
If yes, then how shall we proceed entering the respective CQ for adopting the MIT code into the CDT ?
References:
[2] http://code.google.com/p/elt/
[3]
https://bugs.eclipse.org/bugs/show_bug.cgi?id=360517
[4] https://github.com/rprichard/winpty
Thanks,
Martin
--
Martin Oberhuber, SMTS / Product Architect – Development Tools,
Wind River
direct
+43.662.457915.85 fax
+43.662.457915.6
|