Re: [cdt-dev] Fwd: Build failed in Hudson: cdt-nightly #140

[Olexiy Buyanskyy <olexiyb@xxxxxxxxx>]

On Wed, May 12, 2010 at 11:16 AM, John Cortell <rat042@xxxxxxxxxxxxx> wrote:
> At 10:06 AM 5/12/2010, Doug Schaefer wrote:
>
>> The master zip always gets generated even if there are compile errors.
>
> I've always found this incredibly "reckless", for lack of a better word :-)
> We've been bitten by it before here at Freescale. Is this an Ant/java
> limitation? I'm not in charge of the Eclipse builds here, so I've
> conveniently turned a blind eye to what I figured is some limitation that
> may not be easily overcome.
>
> John
>

I agree with John, that is "reckless" decision. No sense to create
your final target if some piece is broken. I think that is ok to
create master zip file if some tests failed, but not ok if some code
did not compile. When I compile personally CDT I remember how much
time usually it takes to compile. If build took less time then usually
I manually review the build log
There are also several not critical issues

1) create tag before the build. <target name="cdtbuild"
depends="tag,zips,test,upload"/>. if build failed no need to tag
failed build.
2) generate.p2.metadata unzip master file add something to it and zip
back. it looks like overhead to create zip file without p2 data.

		<unzip src="${destination}" dest="${p2dir}"/>
		
		<!-- generate p2 metadata -->
		<antcall target="p2.metadata.generator">
			<param name="p2site" value="${p2dir}"/>
		</antcall>
		
		<!-- zip everything back up -->
		<zip destfile="${destination}"
			basedir="${p2dir}"/>
		<delete dir="${p2dir}"/>


Olexiy