Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[birt-dev] Checkin: fix bugs 195919 BIRT2.1.2 report with allowed blank parameter does not work correctly in BIRT 2.2.0

- Summary:

The main problem causes this issue is that in BIRT 2.1.2 version, allowBlank is true and allowNull is false in ROM. However, in BIRT 2.2, two properties have been removed. Thus, the parser assumes both default values are false.

The fix is to change the default allowNull to true and allowBlank to false during the parser compatibility.


- Bugzilla Bug (s) Resolved: 195919

- Description:

1. fixed the default value in CompatibleParamAllowMumbleState.java, ScalarParameterState.java

2. updated test cases.

- Tests Description :

JUnit/Manual test

- Files Edited:

/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/api/ElementFactoryTest.java
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/api/golden/BoundDataColumnsUtilTest_golden_2.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/api/golden/ElementFactoryTest_golden.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/api/input/BoundDataColumnsUtilTest_2.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/api/input/ElementFactoryTest_1.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/library/golden/LibraryIncludeLibrary_golden.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/ParserCompatibilityTest.java
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/ScalarParameterParseTest.java
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/golden/CompatibleBirt2_1M5Expr_golden.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/golden/CompatibleBoundColumnNestedTable_golden.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/golden/CompatibleScalarParamAllowPropsTest_golden.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/golden/CompatibleScalarParameterFormat_golden.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/golden/ScalarParameterParseTest_golden.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/input/CascadingParameterGroupParserTest.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/input/CompatibleBirt2_1M5Expr.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/input/CompatibleBoundColumnNestedTable.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/input/CompatibleScalarParamAllowPropsTest.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/input/ParameterGroupTest.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/input/ScalarParameterParseTest.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/writer/golden/DocumentUtilTest_external_selectors_golden.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/writer/golden/DocumentUtilTest_golden_2.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/writer/input/DocumentUtilTest_4.xml
/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/writer/input/LibraryCompoundElement.xml
/org.eclipse.birt.report.model_bugs/src/org/eclipse/birt/report/model/parser/CompatibleParamAllowMumbleState.java
/org.eclipse.birt.report.model_bugs/src/org/eclipse/birt/report/model/parser/ScalarParameterState.java



- Files Added:

/org.eclipse.birt.report.model.tests_bugs/test/org/eclipse/birt/report/model/parser/input/ScalarParameterParseTest_1.xml



- Files Deleted:



- Notes to Build Team:



- Notes to Developers:



- Notes to QA:



- Notes to Documentation:

 

 

Rick Lu

 

Actuate Software Shanghai Center

Tel: (86)21-58826388

Fax: (86)21-58826002

Email: rlu@xxxxxxxxxxx


Back to the top