For question2):
BIRT_2_1_2_RC_20070101 is the appropriate one. BIRT_2_1_2_RC_20061227
is not complete due to the internet issue happened those days.
For question 1):
The I-build tags are made on plugin
org.eclipse.birt.releng. Please refresh the tags on org.eclipse.birt.releng to
show them up.
Thanks,
Xiaoying
From:
birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx] On Behalf Of home4slc@xxxxxxxxxxx
Sent: Friday, January 12, 2007
10:44 AM
To: birt-dev@xxxxxxxxxxx
Subject: Fw: [birt-dev] Which
codeline to use for patch contributions? - Cananyone comment?
Can someone help out with the two remaining questions
I have?
-----
Forwarded Message ----
From: "home4slc@xxxxxxxxxxx" <home4slc@xxxxxxxxxxx>
To: Wenfeng Li
<wli@xxxxxxxxxxx>; birt-dev@xxxxxxxxxxx
Sent: Wednesday, January 10, 2007 1:39:10 PM
Subject: Re: [birt-dev] Which codeline to use for patch contributions?
I'm still a little bit confused about two things.
I'm not sure what you mean by the latest I-build
tag. When I look under Versions > source I don't see any versions that
have an 'I' build designation. Just 'Nightly', 'RC', 'Stable', 'M',
'Release'. Should at least one of them be marked with an I?
So it sounds like I should check out the 2.1.2 stream
to submit a patch for past versions of BIRT, my question is, do I always check
out the most current version?
Looking under Versions > Source I see
BIRT_2_1_2_RC_20070101 and BIRT_2_1_2_RC_20061227. Which of these is
appropriate?
----- Original
Message ----
From: Wenfeng Li
<wli@xxxxxxxxxxx>
To: home4slc@xxxxxxxxxxx; birt-dev@xxxxxxxxxxx
Sent: Wednesday, January 10, 2007 9:31:39 AM
Subject: RE: [birt-dev] Which codeline to use for patch contributions?
The BIRT wiki FAQ is the place to contribute this
information.
Just thought of one thing to add to the answer to (1)
If you are looking for the set of source codes that
can compile and had passed basic smoke test, please use the latest I-build tag
in the HEAD stream to get the source. The comment on getting the HEAD is
when you are ready to check in you will need to merge your changes with the
HEAD version.
From:
home4slc@xxxxxxxxxxx [mailto:home4slc@xxxxxxxxxxx]
Sent: Wed 1/10/2007 9:28 AM
To: Wenfeng
Li; birt-dev@xxxxxxxxxxx
Subject: Re: [birt-dev] Which
codeline to use for patch contributions?
Thanks for your response. Your answers are very
helpful in understanding how to make contributions. As I mentioned below,
I think this information would be helpful to put on the wiki for other
contributors and potential contributors.
I'd be happy to add this to the wiki and was thinking
about putting it under the Contribution section of the BIRT/FAQ/Birt Project
page;
Does that seem like the best place to put it, or do
you have a suggestion for a different location?
----- Original
Message ----
From: Wenfeng Li
<wli@xxxxxxxxxxx>
To: Susan Cline <home4slc@xxxxxxxxxxx>; birt-dev@xxxxxxxxxxx
Sent: Tuesday, January 9, 2007 4:24:15 PM
Subject: RE: [birt-dev] Which codeline to use for patch contributions?
1) To contribute a patch to the most recent version of
the BIRT source do we check out
the source from the Head? For example,
/cvsroot/birt > HEAD > source?
Should we check it out from /cvsroot/birt >
Versions > source > source BIRT_2_2_X latest?
[wli] Please check
out the HEAD version.
2) How can I contribute a patch to an already released
version of BIRT, or a release candidate of BIRT?
For instance, for a bug that has been fixed in 2.2,
but exists in 2.1.1 and 2.1.2 which version of BIRT do we check out and create
a patch for? Can patches be back ported? If so, how?
[wli] Bugs can be
backported to previous release streams. release stream is created for
each 2nd digit release. For example 2.1.x release stream, 2.2.x release
streams. It is possible to back port bug fixed in 2.2 to 2.1.2 but
not 2.1.1, since the latest release vehicle for the 2.1.x stream is 2.1.2.
However, such back port will also depends on the risk and scope of changes on
the code base. The committer for the related component will evaluate the
risk of back porting a bug. When a committer decide to backport a
bug, he/she will check into that target release CVS stream, and update the
tag and map files to include the fix in next build on that stream (the 2.1.2
stream for example).
3) When contributing a patch, is it necessary to note
in the bugzilla entry which version of BIRT the patch was created from? (Especially
in the case above.)
[wli] yes, please set the
target milestone to that release, and if the fix is for multiple release,
please set the target release to the latest one, but also put in
comment all release stream that needs this fix.
4) Is it a requirement to run all JUnit tests against
any patch submitted? Against some patches?
[wli] It is recommended
to test as much as you can with you patch. But the committer(s) who
reviews and checks in the patch will also run the unit tests he/she has before
check in. Frequently, they might also revise the patch before check in.
-----Original
Message-----
From: birt-dev-bounces@xxxxxxxxxxx
[mailto:birt-dev-bounces@xxxxxxxxxxx] On
Behalf Of Susan Cline
Sent: Tuesday, January 09, 2007
2:25 PM
To: birt-dev@xxxxxxxxxxx
Subject: [birt-dev] Which codeline
to use for patch contributions?
I have some questions about contributing patches to
the BIRT source. I can not find answers to these on the BIRT web site,
wiki or in the newsgroup. If I have overlooked this information, please
let me know where I can find it.
The instructions on the website explain about building
BIRT from CVS, and apply to the 2.1.1 version, but don't mention which
version of BIRT should be used for creating patches.
1) To contribute a patch to the most recent version of
the BIRT source do we check out
the source from the Head? For example,
/cvsroot/birt > HEAD > source?
Should we check it out from /cvsroot/birt >
Versions > source > source BIRT_2_2_X latest?
2) How can I contribute a patch to an already released
version of BIRT, or a release candidate of BIRT?
For instance, for a bug that has been fixed in 2.2,
but exists in 2.1.1 and 2.1.2 which version of BIRT do we check out and create
a patch for? Can patches be back ported? If so, how?
3) When contributing a patch, is it necessary to note
in the bugzilla entry which version of BIRT the patch was created from?
(Especially in the case above.)
4) Is it a requirement to run all JUnit tests against
any patch submitted? Against some patches?
I'd be happy to create a wiki page with this
information if someone can answer these questions.
|